search

unitedstates / contact-congress

Sending electronic written messages to members of Congress by reverse engineering their contact forms.
https://theunitedstates.io/contact-congress/
Creative Commons Zero v1.0 Universal
631 stars 211 forks source link

Remove "required" flag for check/uncheck #595

Closed sinak closed 10 years ago

sinak commented 10 years ago

It's a bit confusing. Perhaps also change the label to say "Check this" or "Uncheck this." Also the first option "---" could be changed to "--- (leave with default)"

drinks commented 10 years ago

So, sometimes a check direction is actually a required step, this often happens with the 'do you want a response' radio buttons. Required should be considered a boolean proxy for "does this have a star next to it on the form" and not much else. Agree that it's maybe a little confusing, but sorta necessary.— Dan Drinkard

On Tue, Apr 8, 2014 at 1:44 AM, Sina notifications@github.com wrote:

It's a bit confusing. Perhaps also change the label to say "Check this" or "Uncheck this." Also the first option "---" could be changed to "--- (leave with default)"

Reply to this email directly or view it on GitHub: https://github.com/unitedstates/contact-congress/issues/595

sinak commented 10 years ago

Hmm, I think the only times a star is used next to a form field is if it's something akin to "I agree to this site's privacy policy" or something along those lines, which prevents you from submitting the form if it isn't checked.

Having a required checkbox for something like "Do you want a response?" seems a bit weird otherwise? Won't we by default just check that box for every message sent?

drinks commented 10 years ago

Sorry, the nomenclature 'required' here literally means just those things that will prevent the form from submitting if they're not filled in--saying nothing of the data we are requiring from users but rather what do the legislators themselves require. Often the 'would you like a response' radio set is required in that sense (and 99% of the time all required fields have a star next to them on the source forms). Maybe best to hash this out on a hangout tomorrow?— Dan Drinkard

On Tue, Apr 8, 2014 at 1:54 AM, Sina notifications@github.com wrote:

Hmm, I think the only times a star is used next to a form field is if it's something akin to "I agree to this site's privacy policy" or something along those lines, which prevents you from submitting the form if it isn't checked.

Having a required checkbox for something like "Do you want a response?" seems a bit weird otherwise? Won't we by default just check that box for every message sent?

Reply to this email directly or view it on GitHub: https://github.com/unitedstates/contact-congress/issues/595#issuecomment-39814109

j-ro commented 10 years ago

FWIW, I agree that the YAML should be technical requirements rather than UI decisions. As different systems may implement the YAML differently...

sinak commented 10 years ago

I guess I still don't understand how you can "require" a check box that asks the user whether they want a response. Surely those contact forms can be submitted even if the user doesn't want a response? In which case, it doesn't seem like a required field?

contactcongress commented 10 years ago

Ah ok. It's unselected by default and required that you pick yes or no (radio button). Radios use the same mechanism as standard checkboxes.— Dan Drinkard

On Wed, Apr 9, 2014 at 6:00 PM, Sina notifications@github.com wrote:

I guess I still don't understand how you can "require" a check box that asks the user whether they want a response. Surely those contact forms can be submitted even if the user doesn't want a response? In which case, it doesn't seem like a required field?

Reply to this email directly or view it on GitHub: https://github.com/unitedstates/contact-congress/issues/595#issuecomment-40021901

sinak commented 10 years ago

Aha, yep. I just ran across this in a Rep. Cassidy's contact form actually. Do we hardcode the value as yes for the "Do you want a response?" questions?

contactcongress commented 10 years ago

select = as previously emailed, radio = the yes option gets set to [checked]

On Wed, Apr 9, 2014 at 11:18 PM, Sina notifications@github.com wrote:

Aha, yep. I just ran across this in a Rep. Cassidy's contact form actually. Do we hardcode the value as yes for the "Do you want a response?" questions?

Reply to this email directly or view it on GitHubhttps://github.com/unitedstates/contact-congress/issues/595#issuecomment-40039331 .

Dan Drinkard Software Developer Sunlight Foundation

sinak commented 10 years ago

Okay, closing this now.