Open pirtleshell opened 7 years ago
Thanks, I'll add these.
Running python scripts/missing.py
shows there's quite a number missing:
---
Not found: congress/original/D000626.jpg
{'last': 'Davidson', 'official_full': 'Warren Davidson', 'first': 'Warren'}
---
Not found: congress/original/C001108.jpg
{'last': 'Comer', 'official_full': 'James Comer', 'first': 'James'}
---
Not found: congress/original/E000296.jpg
{'last': 'Evans', 'official_full': 'Dwight Evans', 'first': 'Dwight'}
---
Not found: congress/original/H001075.jpg
{'last': 'Harris', 'official_full': 'Kamala D. Harris', 'first': 'Kamala'}
---
Not found: congress/original/K000393.jpg
{'middle': 'Neely', 'official_full': 'John Kennedy', 'last': 'Kennedy', 'first': 'John'}
---
Not found: congress/original/H001076.jpg
{'middle': 'Wood', 'nickname': 'Maggie', 'official_full': 'Margaret Wood Hassan', 'last': 'Hassan', 'first': 'Margaret'}
---
Not found: congress/original/C001113.jpg
{'last': 'Cortez Masto', 'official_full': 'Catherine Cortez Masto', 'first': 'Catherine'}
---
Not found: congress/original/O000171.jpg
{'last': "O'Halleran", 'official_full': "Tom O'Halleran", 'first': 'Tom'}
---
Not found: congress/original/B001302.jpg
{'last': 'Biggs', 'official_full': 'Andy Biggs', 'first': 'Andy'}
---
Not found: congress/original/K000389.jpg
{'last': 'Khanna', 'official_full': 'Ro Khanna', 'first': 'Ro'}
---
Not found: congress/original/P000613.jpg
{'last': 'Panetta', 'official_full': 'Jimmy Panetta', 'first': 'Jimmy'}
---
Not found: congress/original/C001112.jpg
{'last': 'Carbajal', 'official_full': 'Salud O. Carbajal', 'first': 'Salud'}
---
Not found: congress/original/B001300.jpg
{'last': u'Barrag\xe1n', 'official_full': u'Nanette Diaz Barrag\xe1n', 'first': 'Nanette'}
---
Not found: congress/original/C001110.jpg
{'middle': 'Luis', 'official_full': 'J. Luis Correa', 'last': 'Correa', 'first': 'J.'}
---
Not found: congress/original/B001303.jpg
{'last': 'Blunt Rochester', 'official_full': 'Lisa Blunt Rochester', 'first': 'Lisa'}
---
Not found: congress/original/G000578.jpg
{'last': 'Gaetz', 'official_full': 'Matt Gaetz', 'first': 'Matt'}
---
Not found: congress/original/D000628.jpg
{'last': 'Dunn', 'official_full': 'Neal P. Dunn', 'first': 'Neal'}
---
Not found: congress/original/R000609.jpg
{'last': 'Rutherford', 'official_full': 'John H. Rutherford', 'first': 'John'}
---
Not found: congress/original/L000586.jpg
{'last': 'Lawson', 'official_full': 'Al Lawson, Jr.', 'first': 'Al'}
---
Not found: congress/original/M001202.jpg
{'last': 'Murphy', 'official_full': 'Stephanie N. Murphy', 'first': 'Stephanie'}
---
Not found: congress/original/S001200.jpg
{'last': 'Soto', 'official_full': 'Darren Soto', 'first': 'Darren'}
---
Not found: congress/original/D000627.jpg
{'last': 'Demings', 'official_full': 'Val Butler Demings', 'first': 'Val'}
---
Not found: congress/original/C001111.jpg
{'last': 'Crist', 'official_full': 'Charlie Crist', 'first': 'Charlie'}
---
Not found: congress/original/M001199.jpg
{'last': 'Mast', 'official_full': 'Brian J. Mast', 'first': 'Brian'}
---
Not found: congress/original/R000607.jpg
{'last': 'Rooney', 'official_full': 'Francis Rooney', 'first': 'Francis'}
---
Not found: congress/original/F000465.jpg
{'middle': 'Drew', 'first': 'A.', 'official_full': 'A. Drew Ferguson IV', 'last': 'Ferguson', 'suffix': 'IV'}
---
Not found: congress/original/K000391.jpg
{'last': 'Krishnamoorthi', 'official_full': 'Raja Krishnamoorthi', 'first': 'Raja'}
---
Not found: congress/original/B001299.jpg
{'last': 'Banks', 'official_full': 'Jim Banks', 'first': 'Jim'}
---
Not found: congress/original/H001074.jpg
{'last': 'Hollingsworth', 'official_full': 'Trey Hollingsworth', 'first': 'Trey'}
---
Not found: congress/original/M001198.jpg
{'last': 'Marshall', 'official_full': 'Roger W. Marshall', 'first': 'Roger'}
---
Not found: congress/original/H001077.jpg
{'last': 'Higgins', 'official_full': 'Clay Higgins', 'first': 'Clay'}
---
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/B001304.jpg
{'last': 'Brown', 'official_full': 'Anthony G. Brown', 'first': 'Anthony'}
---
Not found: congress/original/R000606.jpg
{'last': 'Raskin', 'official_full': 'Jamie Raskin', 'first': 'Jamie'}
---
Not found: congress/original/B001301.jpg
{'last': 'Bergman', 'official_full': 'Jack Bergman', 'first': 'Jack'}
---
Not found: congress/original/M001201.jpg
{'last': 'Mitchell', 'official_full': 'Paul Mitchell', 'first': 'Paul'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
---
Not found: congress/original/B001305.jpg
{'last': 'Budd', 'official_full': 'Ted Budd', 'first': 'Ted'}
---
Not found: congress/original/B001298.jpg
{'last': 'Bacon', 'official_full': 'Don Bacon', 'first': 'Don'}
---
Not found: congress/original/G000583.jpg
{'last': 'Gottheimer', 'official_full': 'Josh Gottheimer', 'first': 'Josh'}
---
Not found: congress/original/R000608.jpg
{'last': 'Rosen', 'official_full': 'Jacky Rosen', 'first': 'Jacky'}
---
Not found: congress/original/K000390.jpg
{'last': 'Kihuen', 'official_full': 'Ruben Kihuen', 'first': 'Ruben'}
---
Not found: congress/original/S001201.jpg
{'last': 'Suozzi', 'official_full': 'Thomas R. Suozzi', 'first': 'Thomas'}
---
Not found: congress/original/E000297.jpg
{'last': 'Espaillat', 'official_full': 'Adriano Espaillat', 'first': 'Adriano'}
---
Not found: congress/original/F000464.jpg
{'last': 'Faso', 'official_full': 'John J. Faso', 'first': 'John'}
---
Not found: congress/original/T000478.jpg
{'last': 'Tenney', 'official_full': 'Claudia Tenney', 'first': 'Claudia'}
---
Not found: congress/original/F000466.jpg
{'last': 'Fitzpatrick', 'official_full': 'Brian K. Fitzpatrick', 'first': 'Brian'}
---
Not found: congress/original/S001199.jpg
{'last': 'Smucker', 'official_full': 'Lloyd Smucker', 'first': 'Lloyd'}
---
Not found: congress/original/G000582.jpg
{'last': u'Gonz\xe1lez-Col\xf3n', 'official_full': u'Jenniffer Gonz\xe1lez-Col\xf3n', 'first': 'Jenniffer'}
---
Not found: congress/original/K000392.jpg
{'last': 'Kustoff', 'official_full': 'David Kustoff', 'first': 'David'}
---
Not found: congress/original/G000581.jpg
{'last': 'Gonzalez', 'official_full': 'Vicente Gonzalez', 'first': 'Vicente'}
---
Not found: congress/original/A000375.jpg
{'last': 'Arrington', 'official_full': 'Jodey C. Arrington', 'first': 'Jodey'}
---
Not found: congress/original/T000477.jpg
{'last': 'Taylor', 'official_full': 'Scott Taylor', 'first': 'Scott'}
---
Not found: congress/original/M001200.jpg
{'middle': 'Donald', 'official_full': 'A. Donald McEachin', 'last': 'McEachin', 'first': 'A.'}
---
Not found: congress/original/G000580.jpg
{'last': 'Garrett', 'official_full': 'Thomas A. Garrett, Jr.', 'first': 'Thomas'}
---
Not found: congress/original/J000298.jpg
{'last': 'Jayapal', 'official_full': 'Pramila Jayapal', 'first': 'Pramila'}
---
Not found: congress/original/G000579.jpg
{'last': 'Gallagher', 'official_full': 'Mike Gallagher', 'first': 'Mike'}
---
Not found: congress/original/C001109.jpg
{'last': 'Cheney', 'official_full': 'Liz Cheney', 'first': 'Liz'}
http://memberguide.gpo.gov doesn't yet have the 115th congress, so we'll have to wait or do them manually.
yes, there are a bunch. But only four senators so i figured they'd be easy to tackle. Masto doesn't have any CC0 photos I could find though.
GPO will probably be up soon enough!
How's this? https://github.com/unitedstates/images/pull/127
I see someone else has this covered so @hugovk you can close #130. I'm posting here to be updated when it is merged to the master and live on the official site.
As @hugovk noted, there are quite a few legislators with missing photos at the moment. Is there any expectation of when those photos will be scrapeable via the memberguide?
I'm trying to gauge the value of contributing other (fill-in) photos in the meantime. Ie, if those photos are typically available soon, it may be best to just wait for them. If not, providing fill-in photos would be more valuable.
In January 2015, @handlers called the GPO about the 114th, and they estimated it'd be ready in June: https://github.com/unitedstates/images/issues/22#issuecomment-70257135 I'm not sure when they were added, but they were there by October 2015 (https://github.com/unitedstates/images/pull/114), and they'd mostly been manually added in the summer.
It may be worth calling them again to get a new estimate.
Last time round, @nickom did a sterling job in filling in missing images, and then finding better quality images of existing ones. If someone's up for hunting out new ones, it may be worth browsing his closed issues for tips and sources: https://github.com/unitedstates/images/issues?q=is%3Aissue+is%3Aclosed+author%3Anickom+sort%3Acreated-asc
See also: https://github.com/unitedstates/images#contributing-other-photos (we could update this with some tips)
And a note on metadata: https://github.com/unitedstates/images/pull/39#issuecomment-102652836
Just ran a script to report on missing images... sharing results: https://gist.github.com/rthbound/9abeca9b0c4890d58f66d29b3e75bafe
(current as of sometime around this comment's timestamp)
@amp343 @hugovk We have images for the meantime here: https://github.com/unitedstates/images/compare/gh-pages...rthbound:prog-code-patch-1
The original
files are not all *.jpg, so you may want that fixed before merging.
So far we've produced 225x275
and 450x550
for each of the reps mentioned in the gist file above.
The most recent commit explains what's most likely next if we want this merged:
Adds originals. These need to be converted to .jpg of same name (for those that are jpeg or png)
It's been a long few hours of work preparing these, so I'm headed to bed. Will look at converting/renaming the last few originals tomorrow.
Thank you for preparing all those!
Regarding: https://github.com/unitedstates/images#contributing-other-photos https://github.com/unitedstates/images#public-domain
Are they all official/public domain images? Where did each one come from?
They'll also need metadata files, see https://github.com/unitedstates/images/pull/39#issuecomment-102652836
Thanks again!
@hugovk that's what i get for not reading.
I expected we'd want public domain images, so these were the instructions we followed while gathering:
i figure anything .gov is fair game… wikimedia commons, etc… ideally the source image is at least as large as the images we need to produce (size down to fit, preferred)
I'll have to check on the metadata... and do you need the source urls?
EDIT I see the details, thank you for the links and feedback.
Perhaps @konklone and @JoshData can help with those ^ questions.
Ok. Given the instructions, and given that a lawyer and a paralegal helped to carry them out, I expect these are about 99% public domain. I do know that Brian Mast's image came from his facebook somewhere.
We'll take some time to find the attributions before we issue a PR.
I am assuming that the originals do also need to use the .jpg
file extension, so that's one more change we intend to make prior to opening the pull request.
Yes please, let's have them all .jpg, because this says:
Photos are available at predictable URLs, by size and Bioguide ID. Photos are served using GitHub Pages.
https://theunitedstates.io/images/congress/[size]/[bioguide].jpg
If #132 is merged, the following additions to 115th Congress will be outstanding (still missing):
From https://github.com/unitedstates/images/pull/132#issuecomment-277578666
PR #132 is merged, confirmation of the missing:
Not found: congress/original/L000586.jpg
{'last': 'Lawson', 'official_full': 'Al Lawson, Jr.', 'first': 'Al'}
---
Not found: congress/original/H001077.jpg
{'last': 'Higgins', 'official_full': 'Clay Higgins', 'first': 'Clay'}
---
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/R000606.jpg
{'last': 'Raskin', 'official_full': 'Jamie Raskin', 'first': 'Jamie'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
---
Not found: congress/original/T000478.jpg
{'last': 'Tenney', 'official_full': 'Claudia Tenney', 'first': 'Claudia'}
---
Not found: congress/original/G000581.jpg
{'last': 'Gonzalez', 'official_full': 'Vicente Gonzalez', 'first': 'Vicente'}
---
Not found: congress/original/M001200.jpg
{'middle': 'Donald', 'official_full': 'A. Donald McEachin', 'last': 'McEachin', 'first': 'A.'}
---
Not found: congress/original/J000298.jpg
{'last': 'Jayapal', 'official_full': 'Pramila Jayapal', 'first': 'Pramila'}
---
Not found: congress/original/G000579.jpg
{'last': 'Gallagher', 'official_full': 'Mike Gallagher', 'first': 'Mike'}
https://travis-ci.org/unitedstates/images/jobs/199439242#L362
Opened a new issue #138 for missing photos but didn't realize I should probably be referencing this ticket instead. Running scripts/missing.py
gives this output
---
Not found: congress/original/L000586.jpg
{'last': 'Lawson', 'official_full': 'Al Lawson, Jr.', 'first': 'Al'}
---
Not found: congress/original/H001077.jpg
{'last': 'Higgins', 'official_full': 'Clay Higgins', 'first': 'Clay'}
---
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/R000606.jpg
{'last': 'Raskin', 'official_full': 'Jamie Raskin', 'first': 'Jamie'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
---
Not found: congress/original/T000478.jpg
{'last': 'Tenney', 'official_full': 'Claudia Tenney', 'first': 'Claudia'}
---
Not found: congress/original/G000581.jpg
{'last': 'Gonzalez', 'official_full': 'Vicente Gonzalez', 'first': 'Vicente'}
---
Not found: congress/original/M001200.jpg
{'middle': 'Donald', 'official_full': 'A. Donald McEachin', 'last': 'McEachin', 'first': 'A.'}
---
Not found: congress/original/J000298.jpg
{'last': 'Jayapal', 'official_full': 'Pramila Jayapal', 'first': 'Pramila'}
---
Not found: congress/original/G000579.jpg
{'last': 'Gallagher', 'official_full': 'Mike Gallagher', 'first': 'Mike'}
---
Not found: congress/original/S001202.jpg
{'last': 'Strange', 'official_full': 'Luther Strange', 'first': 'Luther'}
Since then I've submitted three PRs #141 #140 and #139 . After those changes the output of missing.py
is
---
Not found: congress/original/L000586.jpg
{'last': 'Lawson', 'official_full': 'Al Lawson, Jr.', 'first': 'Al'}
---
Not found: congress/original/H001077.jpg
{'last': 'Higgins', 'official_full': 'Clay Higgins', 'first': 'Clay'}
---
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/R000606.jpg
{'last': 'Raskin', 'official_full': 'Jamie Raskin', 'first': 'Jamie'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
---
Not found: congress/original/T000478.jpg
{'last': 'Tenney', 'official_full': 'Claudia Tenney', 'first': 'Claudia'}
---
Not found: congress/original/G000581.jpg
{'last': 'Gonzalez', 'official_full': 'Vicente Gonzalez', 'first': 'Vicente'}
---
Not found: congress/original/M001200.jpg
{'middle': 'Donald', 'official_full': 'A. Donald McEachin', 'last': 'McEachin', 'first': 'A.'}
If I submit any further changes I'll reference this ticket instead of #138
Claudia Tenney - T000478 Image URL: https://upload.wikimedia.org/wikipedia/commons/7/7b/Claudia_Tenney%2C_115th_official_photo.jpg Found on: https://commons.wikimedia.org/wiki/File:Claudia_Tenney,_115th_official_photo.jpg License: Public Domain
Donald McEachin - M001200 Image URL: https://upload.wikimedia.org/wikipedia/commons/thumb/3/3b/Donald_McEachin_115th_congress_photo.jpg/1200px-Donald_McEachin_115th_congress_photo.jpg Found on: https://commons.wikimedia.org/wiki/File:Donald_McEachin_115th_congress_photo.jpg License: Public Domain
Clay Higgins - H001077 Image URL: https://upload.wikimedia.org/wikipedia/commons/thumb/9/98/Clay_Higgins_Official_Portrait.jpeg/960px-Clay_Higgins_Official_Portrait.jpeg Found on: https://commons.wikimedia.org/wiki/File:Clay_Higgins_Official_Portrait.jpeg License: Public Domain
Adding the changes in PRs #139 #140 #141 #142 brings the output of missing.py
down to this
---
Not found: congress/original/L000586.jpg
{'last': 'Lawson', 'official_full': 'Al Lawson, Jr.', 'first': 'Al'}
---
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/R000606.jpg
{'last': 'Raskin', 'official_full': 'Jamie Raskin', 'first': 'Jamie'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
---
Not found: congress/original/G000581.jpg
{'last': 'Gonzalez', 'official_full': 'Vicente Gonzalez', 'first': 'Vicente'}
Al Lawson's official 115th Congressional portrait is available here:
Bioguide ID: L000586 Link: https://commons.wikimedia.org/wiki/File:Al_Lawson_115th_Congress_photo.jpg Why Official & Public Domain: Official portrait from 115th Congress
Awesome, just submitted a PR for that image.
Down to 4 missing:
---
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/R000606.jpg
{'last': 'Raskin', 'official_full': 'Jamie Raskin', 'first': 'Jamie'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
---
Not found: congress/original/G000581.jpg
{'last': 'Gonzalez', 'official_full': 'Vicente Gonzalez', 'first': 'Vicente'}
Thanks to @msimonborg for adding two more in https://github.com/unitedstates/images/pull/147.
Now just two remaining:
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
Currently missing:
Not found: congress/original/J000299.jpg
{'last': 'Johnson', 'official_full': 'Mike Johnson', 'first': 'Mike'}
---
Not found: congress/original/L000587.jpg
{'last': 'Lewis', 'official_full': 'Jason Lewis', 'first': 'Jason'}
---
Not found: congress/original/E000298.jpg
{'last': 'Estes', 'official_full': 'Ron Estes', 'first': 'Ron'}
---
Not found: congress/original/G000584.jpg
{'last': 'Gianforte', 'official_full': 'Greg Gianforte', 'first': 'Greg'}
---
Not found: congress/original/N000190.jpg
{'last': 'Norman', 'official_full': 'Ralph Norman', 'suffix': 'Jr.', 'first': 'Ralph'}
---
Not found: congress/original/H001078.jpg
{'last': 'Handel', 'official_full': 'Karen C. Handel', 'first': 'Karen'}
---
Not found: congress/original/G000585.jpg
{'last': 'Gomez', 'official_full': 'Jimmy Gomez', 'first': 'Jimmy'}
Currently missing those from previous comment plus:
Not found: congress/original/C001114.jpg
{'first': 'John', 'last': 'Curtis', 'official_full': 'John Curtis'}
New Senator Photos Missing
When checking for photos of the 115th Congress, four or the seven freshman members of Senate do not yet have photos. This is probably because the GPO hasn't posted the 115th member list and they never served in the House. Here are photos that can be used as placeholders until they become available on GPO:
Kamala D. Harris (D-CA)
John Kennedy (R-LA)
Margaret Wood Hassan (D-NH)
Catherine Cortez Masto (D-NV)
I was unable to find a suitable public domain photo of Senator Masto.