search

unitedstates / inspectors-general

Collecting reports from Inspectors General across the US federal government.
https://sunlightfoundation.com/blog/2014/11/07/opengov-voices-opening-up-government-reports-through-teamwork-and-open-data/
Creative Commons Zero v1.0 Universal
107 stars 21 forks source link

tva bug #116

Closed LindsayYoung closed 10 years ago

LindsayYoung commented 10 years ago

I am having an issue with the Tennessee Valley Authority scraper.

(Also, props to the project for its amazing pace!) 

Traceback (most recent call last):

  File "inspectors/utils/utils.py", line 24, in run
    run_method(cli_options)

  File "inspectors/tva.py", line 36, in run
    report = report_from(result, url, year_range)

  File "inspectors/tva.py", line 58, in report_from
    logging.debug("[%s] Skipping, not in requested range." % report_url)

UnboundLocalError: local variable 'report_url' referenced before assignment
spulec commented 10 years ago

Oops. Fixed this and confirmed there were no other similar instances.

I'm also looking into adding something like pyflakes to Travis-CI for this repo as a basic check.

LindsayYoung commented 10 years ago

Thanks for fixing that so quickly!

konklone commented 10 years ago

:+1: on pyflakes, other repos in this org use that too with Travis. (Also, if you want to add yourself to build notifications, by all means.)

spulec commented 10 years ago

Added with 3b3236cf5e482ce0361163a5ed301bce8e8141f5

@konklone can you setup the Travis hook when you get a minute? I believe it has to be done by someone with admin access on the repo.

konklone commented 10 years ago

Done! And I added my email to it, and just sent a test request, so it should be building as we speak.