search

unitedstates / inspectors-general

Collecting reports from Inspectors General across the US federal government.
https://sunlightfoundation.com/blog/2014/11/07/opengov-voices-opening-up-government-reports-through-teamwork-and-open-data/
Creative Commons Zero v1.0 Universal
106 stars 21 forks source link

Fail hard if a scraper finds no reports #210

Closed divergentdave closed 9 years ago

divergentdave commented 9 years ago

This adds checks throughout the codebase for when select() or find_all() return no elements. An exception will be thrown in such cases. I also fixed three scrapers that were half-broken with such problems.

konklone commented 9 years ago

Wow. @divergentdave, this is an impressively comprehensive refactor and a great move. If this had been in place, we'd have caught some errors a lot earlier on -- and perhaps this will already dig up some errors we weren't noticing. Thank you!