Date fixes - Githubissues

unitedstates / inspectors-general

Collecting reports from Inspectors General across the US federal government.

https://sunlightfoundation.com/blog/2014/11/07/opengov-voices-opening-up-government-reports-through-teamwork-and-open-data/

Creative Commons Zero v1.0 Universal

107 stars 21 forks source link

Date fixes #273

Closed divergentdave closed 8 years ago

divergentdave commented 8 years ago

This will fix #193. The Amtrak OIG website has some dates in the future. (see here) The following scrapers use November 1st of given years as a fallback, and should be changed.

[x] arc
[x] archives
[x] cftc
[x] eac
[x] fca
[x] fec
[x] flra
[x] ftc
[x] gpo
[x] itc
[x] loc
[x] lsc
[x] nea
[x] peacecorps
[x] smithsonian

divergentdave commented 8 years ago

This is ready to go now.

Remove September 1/November 1 fallback dates
Add more hardcoded dates
Log a warning and skip a report when a published date can't be found
Fail report validation when the published date is in the future

konklone commented 8 years ago

Phew!! What a thorough job, thanks @divergentdave!

konklone commented 8 years ago

Deployed to production.