search

unitedstates / unitedstates.github.io

Simple homepage for this organization.
https://theunitedstates.io
Creative Commons Zero v1.0 Universal
52 stars 9 forks source link

Add Senator Stock Watcher + Data Repository To repo list #18

Open timothycarambat opened 4 years ago

timothycarambat commented 4 years ago

Hello,

I am the creator of Senate Stock Watcher and while I already have the data easily accessible and downloaded from the site directly and via an API - I wanted to add my data as a resource for stock trades that are performed and reported by US Senators.

This repo is the raw data for both the daily summaries as they are filed, but also the aggregation of the data that I do each time new reports are filed.

Repo: https://github.com/timothycarambat/senate-stock-watcher-data

dwillis commented 4 years ago

Hey @timothycarambat, thanks! I think this would be a great addition to the project. A couple of things I would suggest, if you're amenable:

  1. Adding the unique bioguide id for members of Congress that we use as a key in most of our data.
  2. Following one of our existing scripts to convert the json into yaml (while retaining the json, too).

Would those be ok?

cc @JoshData

timothycarambat commented 4 years ago

@dwillis Sure, i can make that happen - let me amend the repo! Ill ping you when its ready.

timothycarambat commented 4 years ago

@dwillis the repo now has all files available as .yaml as well as all the summaries now have the bioguide id available.

The only files that do not have those Ids are:

Those files have the senator name as one string so it would be pretty difficult to parse since some names have a middle initial, some names are full (Michell McConnel => Mitch McConnell), some have a suffix like Jr/Sr., etc.

Those two files are the only exception due and I feel that is permissible since those two particular files revolve around a single ticker or are about single transactions. This data is also duplicated inside the other two aggregate files or daily summaries.