search

unitedworldwrestling / arena-public

14 stars 5 forks source link

Technical points' input needs to be sanitized #23

Closed theswix closed 3 years ago

theswix commented 3 years ago

Which application you are experiencing a problem with Arena 1.5.72.1

Describe the bug Arena allows to input non-existing in wrestling rules technical points for the match, and happily saves the result with unrealistic numbers.

To Reproduce Steps to reproduce the behavior:

  1. Create match
  2. Add points including unreal ones like "7", "9" etc.
  3. Close the match
  4. See unrealistic results of the match.

Expected behavior To sanitize technical points' input not allowing anything except real-world points in wrestling (i.e. "1", "2", "4", "5")

Screenshots IMG_20210404_174939 IMG_20210404_174920

csabavirag commented 3 years ago

Hello @theswix This enhancement is available starting from Arena version 1.5.77.

You will get a popup if you try to enter a technical point not configured for the appropriate Sport (style) image

You can review/modify the accepted points via Settings -> Sports Config. Every sport has their "pointAlias" attribute where the accepted points are defined. image