unitsofmeasurement / indriya

JSR 385 - Reference Implementation
Other
119 stars 40 forks source link

Use Number instead of Long to represent values in temporal Quantities. #227

Closed andi-huber closed 5 years ago

andi-huber commented 5 years ago

This change is Reviewable

andi-huber commented 5 years ago

part of #220 Further simplifies Temporal Quantity implementations.

andi-huber commented 5 years ago

Would be @since 2.0 OK for TimeUnitQuantity.getValue()?

keilw commented 5 years ago

It depends because getValue() was always there, maybe to avoid confusion leave it as 1.0 for the existence. Broadening it to Numberchanges nothing on the outside.

andi-huber commented 5 years ago

Thx. I've updated this PR accordingly.