235: add maven profile 'm2e' that activates on eclipse

unitsofmeasurement / indriya

JSR 385 - Reference Implementation

Other

122 stars 42 forks source link

235: add maven profile 'm2e' that activates on eclipse #236

Closed andi-huber closed 5 years ago

andi-huber commented 5 years ago

to specifically fix eclipse build and test issues

fixes #235

This change is

andi-huber commented 5 years ago

I'd be surprised if this change breaks the maven build. (However, unless really tested we can't be sure.)

andi-huber commented 5 years ago

Its a profile that only activates when m2e is present, which is the name of the maven integration for eclipse. Its specifically meant to fix build issues when checking out with eclipse and then also build with eclipse's own java compiler and later test with eclipse's Junit 5 integration. The resulting build is not meant as a release build.

So we could rename the profile to 'eclipse' if you prefer, but I'd not recommend the generic 'java8' name for this particular profile.

andi-huber commented 5 years ago

... this profile should not even be required, but unfortunately 'm2e' does still require a workaround and the Jupiter integration of eclipse requires depends on newer JUnit versions than the official RI build.

keilw commented 5 years ago

So when you run it in the commandline it works without that profile?