test: add a test to check base units are stored in correct order

unitsofmeasurement / indriya

JSR 385 - Reference Implementation

Other

118 stars 40 forks source link

test: add a test to check base units are stored in correct order #260

Closed sendilkumarn closed 4 years ago

sendilkumarn commented 4 years ago

Fixes #133

r? @thodorisbais

This change is

teobais commented 4 years ago

Hey @sendilkumarn , thanks a lot for this one. Although this PR adds code on a test, it is still considered code modification, for which one needs to be a JCP Member in order to merge.

Last Wednesday we requested for an Associate Membership. Is that already approved?

sendilkumarn commented 4 years ago

Is that already approved?

Yes.

sendilkumarn commented 4 years ago

@andi-huber check the linked issue #133. To be honest I don't find a perfect place to put this test case so added it in this file.

It seems indentation got lost, can you correct that?

I don't think there is a problem in the indentation, my IDE doesn't complain about it. The last } that you see is kinda misleading in the GitHub diff. But hope it is correct. Let me know if you feel otherwise.

andi-huber commented 4 years ago

Ok thanks! Don't want to veto this PR, but if this test-case is justified, it seems we also need to update some java-doc. Maybe I'm just confused.