search

unitsofmeasurement / indriya

JSR 385 - Reference Implementation
Other
118 stars 40 forks source link

isEquivalentTo issue ? #268

Closed vincentlejeune closed 4 years ago

vincentlejeune commented 4 years ago

This test failed, from my understanding, it seems a bug. Could you confirm please ?


    public void should_multiply(){
        ComparableQuantity<javax.measure.quantity.Length> km3 = getQuantity(3, KILO(METRE));
        ComparableQuantity<javax.measure.quantity.Length> km2 = getQuantity(2, KILO(METRE));
        ComparableQuantity<javax.measure.quantity.Area> area = km3.multiply(km2, javax.measure.quantity.Area.class);
        assertThat(area.isEquivalentTo(getQuantity(6, KILO(SQUARE_METRE)))).isTrue();
    }```
andi-huber commented 4 years ago

how about KILO(SQUARE_METRE) -> MEGA(SQUARE_METRE)

andi-huber commented 4 years ago

1 mega (m^2) == 1 (km)^2

vincentlejeune commented 4 years ago

@andi-huber thanks for your help. My bad ... This one works.


        ComparableQuantity<javax.measure.quantity.Length> km3 = getQuantity(3, KILO(METRE));
        ComparableQuantity<javax.measure.quantity.Length> km2 = getQuantity(2, KILO(METRE));
        ComparableQuantity<javax.measure.quantity.Area> area = km3.multiply(km2, javax.measure.quantity.Area.class);
        assertThat(area.isEquivalentTo(getQuantity(6, MEGA(SQUARE_METRE)))).isTrue();
    }
andi-huber commented 4 years ago

cool, no worries