search

unitsofmeasurement / indriya

JSR 385 - Reference Implementation
Other
118 stars 40 forks source link

Remove duplicated maven-surefire-plugin #276

Closed pzygielo closed 4 years ago

pzygielo commented 4 years ago

Due to:

[WARNING] Some problems were encountered while building the effective model for tech.units:indriya:bundle:2.0.3-SNAPSHOT
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-surefire-plugin @ line 286, column 12
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.

This change is Reviewable

pzygielo commented 4 years ago

Are you sure, this works without it, e.g. tried it locally?

Yes, before pushing to github I did run it locally, (up to verify phase). On travis you can see tests run:

[WARNING] Tests run: 1069, Failures: 0, Errors: 0, Skipped: 18

and coverage checks passed:

[INFO] All coverage checks have been met.

Last time we looked at this a later Surefire plugin was incompatible with the code coverage tool and the build would break, thus I won't merge unless it is 100% sure not to break anything.

The duplicate of section I propose to remove, is still there at new line 265.

keilw commented 4 years ago

Travis is only the secondary CI, but good to hear, it seems to work there.