search

unitsofmeasurement / seshat

Seshat Units of Measurement Implementation
Apache License 2.0
7 stars 3 forks source link

Build broken for so long? #17

Closed keilw closed 2 years ago

keilw commented 2 years ago

Why is the build broken for such a long time, @desruisseaux any idea or something you changed?

desruisseaux commented 2 years ago

I was not aware that it was broken. Thanks for spotting it! The CI said:

No .circleci/config.yml was found in your project.

But that file exists. I will investigate more tomorrow. I'm very novice in CircleCI, so if you have any hints, than would be greatly appreciated!

keilw commented 2 years ago

That's weird, but can you check the version in that YML, it might be outdated and no longer recognized especially if it's 1.x. You can see the files in the API or other project repos as a guideline.

desruisseaux commented 2 years ago

I think the key error is:

Failed to collect dependencies at tech.units:unit-tck:jar:1.1 ->
Failed to read artifact descriptor for org.jboss.test-audit:jboss-test-audit-impl:jar:1.1.0.Final:
Could not transfer artifact org.jboss.test-audit:jboss-test-audit-impl:pom:1.1.0.Final from/to
maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories:
    [jcenter (http://jcenter.bintray.com, default, releases+snapshots),
    bintray-release (http://oss.jfrog.org/artifactory/libs-release, default, releases),
    bintray-snapshot (http://oss.jfrog.org/artifactory/libs-snapshot, default, releases+snapshots),
    bintray-uom (http://dl.bintray.com/unitsofmeasurement/maven, default, releases+snapshots)]

So it may be because the jcenter/bintray repositories are now retired. I presume that those dependencies have been fixed in tech.units:unit-tck:2.1.1 and that the best action would be to upgrade (at last) Apache SIS and Seshat to JSR-385. I agree that I'm very, very, very, sooo late on this long due work…

For short term I will check if I can override the repository link.

keilw commented 2 years ago

Possible, the 1.1 TCK was not changed ever since 2018 or so. As the demand for independent implementations or challenges to the TCK seems very low, I would prefer not to redeploy a 1.1.1 or similar if we can avoid that, so let us know here, if building it prior to a JSR 385 migration (which given Oracle also does not support e.g. Java 7, 9 or 10 either, should be done wherever possible ;-)

desruisseaux commented 2 years ago

I believe that the issue is described there:

I'm not sure if I can fix that with a Maven config. The best fix would probably be to upgrade to JSR-385 before the OGC code sprint.

No need to deploy a TCK 1.1.1. I think the effort shoudl be put in upgrading Seshat to JSR-385. Thanks for your help and help proposal :-)

desruisseaux commented 2 years ago

Fixed as a side-effect of #14.