Get Codacy grade to A

[keilw]

The Codacy grade is currently B, it should be A.

List of Codacy suggestions to be ignored/muted:

• Use equals() to compare object references. An overall amount of 2 issues: (src/main/java/javax/measure/spi/ServiceProvider.java, src/main/jdk9/javax/measure/spi/ServiceProvider.java).
• Method names should not start with capital letters (that was decided on #165). An overall amount of 28 issues: (src/main/java/javax/measure/BinaryPrefix.java and src/main/java/javax/measure/MetricPrefix.java)

[desruisseaux]

We should not follow blindly Codacy (or any other tools) diagnostic. All tools have false positives, sometime in large amount. If Codacy said that a code needs to be changed, its suggestions need to be investigated on a case-by-case basis. Many times the tools is wrong.

[keilw]

It can be configured to skip or permanently ignore what is not appropriate for our situation. E.g. the constant prefixes.

[teobais]

@desruisseaux couldn't agree more, that was also my meaning here.

[teobais]

Taking into account the discussion above, as well as the discussion at #166 , we cannot accept each and every suggestion from Codacy (due to our standards, roadmap, etc.). That said, we need to keep a list with the issues we need to manually mute/ignore at Codacy.

Initiated that list above.

[keilw]

The https://app.codacy.com/project/unitsofmeasurement/unit-api/dashboard shows some issues, not sure, why https://app.codacy.com/project/unitsofmeasurement/unit-api_2/dashboard is different, if it's a matter of configuration let's try to consolidate it and delete the duplicate.

[teobais]

As I mentioned some time ago (in another issue or PR, I cannot recall at the moment), I have accidentally created unit-api_2 project while playing around with Codacy. However, given that I have no write rights, I think it's kinda impossible to delete it from my side. So, @keilw , I would suggest that I'm given some write rights to play a bit more, consolidate the two and delete the redundant one, so that we can move forward.

[keilw]

I'll try to delete it, thanks for explaining

[teobais]

Cool, hope we figure it out soon!

[teobais]

On #165 we decided to stick with prefixing method names with an uppercase letter. Hence, we should also mute related Codacy issues (an overall amount of 28 issues). Updated this issue.

[keilw]

Yes, that's a good idea, thanks.

[teobais]

By the way, did we manage to find a way to mute/ignore issues on our codacy project?

[keilw]

Not sure, if it needs admin rights in the Codacy profile but yes, they can be ignored either per incident or for an entire file or pattern (e.g. that "must not start with uppercase")

[teobais]

I think it needs; I'm currently only able to see these two projects (as I've mentioned some time ago):

And even in the fore-mentioned one, I only have read rights, so, I cannot do that much.