search

unitsofmeasurement / unit-api

Units of Measurement API
http://unitsofmeasurement.github.io/unit-api/
Other
182 stars 42 forks source link

Remove Todo comments exist in pom.xml file while the related issues are already fixed. #208

Closed markxiaotao closed 4 years ago

markxiaotao commented 4 years ago

I think the fix of https://issues.apache.org/jira/browse/MANTRUN-214 had been already applied to the associated part, but the comments still exist. The two comments could be removed.

Comment 1: https://github.com/unitsofmeasurement/unit-api/blob/99737c2f555baf254abfe4147a34612714b13bb2/pom.xml#L466-L467

Comment 2: https://github.com/unitsofmeasurement/unit-api/blob/99737c2f555baf254abfe4147a34612714b13bb2/pom.xml#L860-L861

This change is Reviewable

keilw commented 4 years ago

Thanks, are you a JCP Member by any chance? Because in the API and RI repositories one should at least be an Associate member, although this change is relatively small, for other projects this is not required.

keilw commented 4 years ago

Actually we had 2 or 3 others make changes to the POM only, so it seems OK. You are more than welcome to join the JCP if you plan to contribute more.

markxiaotao commented 4 years ago

I am not a JCP member, now. I am sorry not to check the contribution guide before submitting this pulls request. In a research project, we analyzed the build file of repositories in GitHub looking for comments with ready-to-be-addressed SATDs (self-admitted technical debt) that could be addressed. Then we found these two comments.

Thank for understanding!

keilw commented 4 years ago

No worries, I was able to merge it because for POM or CI related config files we made those exceptions before. Since they don't go into the spec or API it is less problematic, if someone wanted to change a Java file, then it is highly recommended that they join the JCP at least as an Associate. Thanks for your help with that.