search

unitsofmeasurement / unit-api

Units of Measurement API
http://unitsofmeasurement.github.io/unit-api/
Other
182 stars 42 forks source link

Improve code coverage of ServiceProvider #219

Closed keilw closed 1 year ago

keilw commented 3 years ago

At the moment ServiceProvider has a lower code coverage which affects the overall metrics for the project. Should be above 80% for Sonatype. While the new annotations or also existing javax ones can be tested via extension modules or the RI there are no tests here. Either ServiceProvider should be excluded from JacoCo or we get a test in here that also tests those annotations.

Oliver-Loeffler commented 2 years ago

Haven't been here for a while, but after some playing around and reviewing I've a strategy to improve coverage, so there will be a PR soon for discussion.

desruisseaux commented 2 years ago

Note: pull request #242 (if accepted) should probably be merged before to work on test coverage.

keilw commented 1 year ago

With the latest PRs up to #251 the coverage has gone up to nearly 90%. We may never get to 100, but that is a pretty good improvement and also marked in green, hence closing this ticket.