search

unitsofmeasurement / uom-systems

Units of Measurement Systems
http://www.uom.systems
Other
36 stars 17 forks source link

Dimension of BEL_WATT and BEL_KILOWATT is wrong #178

Closed frank-montyne closed 3 years ago

frank-montyne commented 4 years ago

The dimension of BEL_WATT and BEL_KILOWATT should be level of power instead of level of electric potential. It is stated correctly in the comments but wrongly defined:

/** power level */
public static final Unit<Level<ElectricPotential>> BEL_WATT = addUnit(
     WATT.transform(new LogConverter(10)).asType(Level.class));

public static final Unit<Level<ElectricPotential>> BEL_KILOWATT = addUnit(
     KILO(WATT).transform(new LogConverter(10)).asType(Level.class));

should be:

public static final Unit<Level<Power>> BEL_WATT = addUnit(
     WATT.transform(new LogConverter(10)).asType(Level.class));

   public static final Unit<Level<Power>> BEL_KILOWATT = addUnit(
     KILO(WATT).transform(new LogConverter(10)).asType(Level.class));

See also Finnish thesaurus and ontology service: ucum

keilw commented 4 years ago

Seems a copy/paste mistake from BEL_VOLT. Thanks for spotting that. You are welcome to create a PR if you can, otherwise we plan to fix that with the 2.1 release train which is supposed to follow that of the main JSR deliverables like API, RI or TCK in Q4.

frank-montyne commented 4 years ago

I just created a PR.

On Mon, Oct 26, 2020 at 1:50 PM Werner Keil notifications@github.com wrote:

Seems a copy/paste mistake from BEL_VOLT. Thanks for spotting that. You are welcome to create a PR if you can, otherwise we plan to fix that with the 2.1 release train which is supposed to follow that of the main JSR deliverables like API, RI or TCK in Q4.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/unitsofmeasurement/uom-systems/issues/178#issuecomment-716524734, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJKQL3G6UHKWZ5WDURSSZTSMVWAHANCNFSM4S6HLS7Q .

keilw commented 4 years ago

I'll check it out, thanks. Especially in UCUM we have a contributors file, would you like to be mentioned there?

frank-montyne commented 4 years ago

Maybe next time, this was a really small thing...

Best regards, Frank

On 26 Oct 2020, at 16:46, Werner Keil notifications@github.com wrote:

 I'll check it out, thanks. Especially in UCUM we have a contributors file, would you like to be mentioned there?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.