App-package-gen and unity-app-gen must be pinned to releases not the main branch

unity-sds / unity-ads-deployment

Apache License 2.0

0 stars 6 forks source link

App-package-gen and unity-app-gen must be pinned to releases not the main branch #166

Closed mike-gangl closed 2 months ago

mike-gangl commented 4 months ago

https://github.com/unity-sds/unity-ads-deployment/blob/bc07f0d509a08823933bd212439ee962c8cc83b3/ci_cd/install_group_runner_x86_64_shell.tftpl#L187-L191

Anytime a new gitrunner is deployed (or if the instance crashes and a new one is brought up) it will fetch the lates code regardless of if it's been tested or not. By pinning this to a release or a specific commit hash, we know what will be deployed regardless of when the deployment happens.

mike-gangl commented 4 months ago

Any updates on this?

mcduffie commented 4 months ago

Use

app-pack-generator v0.4.0
unity-app-generator v0.3.0

mcduffie commented 4 months ago

Preliminary support here: https://github.com/unity-sds/unity-ads-deployment/commit/ac234e815d8ce2bbb5aa6bcc118114f5ecf31654

edwinsarkissian commented 4 months ago

This task is complete. When the U-ADS "auto clone/build pipeline" is deployed, unity-app-gen and app-pack-gen are installed for the selected tags. Currently, the defaults are 0.4.0 for app-pack-gen and 0.3.0 for unity-app-gen.

mike-gangl commented 2 months ago

@edwinsarkissian or @mcduffie please close the ticket if you're done.