unity-sds / unity-ads-deployment

Apache License 2.0
0 stars 6 forks source link

Modify application build process with selectable unity-app-generator versions #168

Closed mcduffie closed 2 months ago

mcduffie commented 4 months ago

Control over the version of unity-app-generator used needs to be moved to a location that allows for more rapid deployment. The current method of baking the software into the Gitlab runner does not allow easily updating. Instead unity-app-generator at a specific version number should be deployed as a step before building the application. This additionally helps document in build logs what version of the app package generator was used.

Steps to correct:

mcduffie commented 4 months ago

Steps:

  1. Modify instance environment to install certain versions, test
  2. Move to YAML afterwards with a version tag
  3. Add passing of parameter to Gitlab from Lambda
  4. Modify Gitlab YAML to use passed parameter
mcduffie commented 4 months ago

Use a Python virtual environment to install unity-app-generator and app-pack-generator into temporary directory for each pipeline build.

Place versions into ssm_parameters that do not get overwritten by Terraform if they already exist.

https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle#ignore_changes

mcduffie commented 4 months ago

Not an obvious how to pass parameters to the automatically triggered app pack pipeline. Only have the ability to pass parameters to mcp-clone pipeline.

Will modify the .gitlab-yaml copied by mcp_clone to inject the version when copying into the repo.

mcduffie commented 3 months ago

Requires implementing issue #169 first.

mcduffie commented 3 months ago

Work done in parallel with #169

Updating unity-app-build-trigger to modify mcp_clone script to accept the venue name as a passed argument. Modify .gitlab.yaml to be a template with values replace with the venue name and versions for unity-app-gen. Modifications made to runner script to use these arguments in the build process.

Remaining work:

mcduffie commented 3 months ago

Implemented selection of versions to the Lambda.

Remaining work: