unity-sds / unity-cs

Unity Common Services
Apache License 2.0
0 stars 2 forks source link

Fix the broken Management Console Deployment due to GH Token #383

Open galenatjpl opened 7 months ago

galenatjpl commented 7 months ago

Fix broken deployments. See slack for details. Zip file not getting created.

hargitayjpl commented 7 months ago

@jpl-btlunsfo

https://github.com/unity-sds/unity-management-console

Image

The management console setup process is failing here. It's trying to get the newest version of the management consoles, but the latest version is missing the ".zip" file in its package.

Image

The most recent version doesn't include the ".zip" file for the Management console. This issue is happening because there's a problem with the GitHub Actions, which are supposed to run when someone adds a new tag in the GitHub management-console repository. We think The GitHub Actions are failing because the GitHub secret token isn't set in the repository.

Image

You can use the GitHub secret token from @galenatjpl. You'll find this token in the Unity-cm venue under the parameter name `/unity/cs/githubtoken'

To test it push a new tag and see if the GH actions succeed if it does double check and make sure the ".zip" is in the version release.

jpl-btlunsfo commented 7 months ago

Would it be possible to tag a non-main branch, or should I push directly to main?

Attempted to create the GITHUB_TOKEN repository secret in settings, but got an error back stating secrets/variables starting with GITHUB_ are disallowed. Created a GH_TOKEN secret instead, but hooking it into the action would involve modifying .github/workflows/release.yml.

jpl-btlunsfo commented 7 months ago

change seems to have built successfully: https://github.com/unity-sds/unity-management-console/actions/runs/8805913117/job/24169527250

jpl-btlunsfo commented 7 months ago

moving forward, due to the way the github actions deliver the release, new releases should be triggered through tag creation, not release drafting.

git tag -a 0.4.6.1
git push origin 0.4.6.1