search

unity-sds / unity-cs

Unity Common Services
Apache License 2.0
0 stars 1 forks source link

Rework proxy lambda SSM name in ui infra code #402

Open galenatjpl opened 1 month ago

galenatjpl commented 1 month ago

This line needs to be modified:

https://github.com/unity-sds/unity-ui-infra/blob/a40e2fa222b90fcbca61c31f84a33efa58199325/terraform-unity-ui/main.tf#L12

To have the same format as the change made here:

https://github.com/unity-sds/unity-proxy/pull/1/files

anilnatha commented 1 month ago

@galenatjpl I have updated the referenced line in my working branch. I'm currently reading through Mike's HTTPD Proxy example to update the rest of the UI infrastructure to work with HTTPD as well.

https://github.com/unity-sds/unity-ui-infra/blob/initial-marketplace-integration/terraform-unity-ui/main.tf#L12

galenatjpl commented 1 month ago

@anilnatha , apologies, but it will most likely NOT be the case that you will need to use the HTTPD proxy lambda in the form that it currently is in. It's still good that you made this change. We might still need the lambda to trigger changes, but there is a new SSM-based methodology that @jpl-btlunsfo has been working on, that he and/or U-CS can help explain to you soon, perhaps in another hackathon or Unity team meeting. @mike-gangl @GodwinShen