unity-sds / unity-cs

Unity Common Services
Apache License 2.0
0 stars 2 forks source link

Move the cloudformation cfn repo code into a sub-directory of unity-cs-infra repo #443

Closed galenatjpl closed 3 months ago

galenatjpl commented 3 months ago

The private fork/repo at: https://github.com/unity-sds/cfn-ps-jpl-unity-sds/tree/main should not be needed to be private, and should be consolidated into the https://github.com/unity-sds/unity-cs-infra repository.

1) The cfn repository should be reviewed to see if there is anything sensitive in there, that would make it hard to publish to open-source.

2) Not all of the code in the cfn repo is actually needed, so as part of the copy and paste into the infra repo, only code that's actually needed should be copied over.

3) Code in the scripts that previously referenced the cfn repo should be removed, and cleaned up. For example: https://github.com/unity-sds/unity-cs-infra/blob/594fa9484910c1780e06d87b06ba433b4785c9c3/nightly_tests/run.sh#L209

4) The script should be refactored to use the new sub-directory that gets created as part of this ticket. This will also avoid the need to clone the cfn repo underneath the working directory.

5) Finally, after this is all tested, the cfn repository should be archived, or deleted.