updated networking ssm param to be consistent with cs-infra

unity-sds / unity-monorepo

Apache License 2.0

0 stars 0 forks source link

updated networking ssm param to be consistent with cs-infra #35

Open galenatjpl opened 2 months ago

galenatjpl commented 2 months ago

Purpose

updated networking ssm param to be consistent with cs-infra PR: https://github.com/unity-sds/unity-cs-infra/pull/98

drewm-jpl commented 2 months ago

Are service areas migrating their terraform to this repo?

galenatjpl commented 2 months ago

@drewm-jpl I'm not sure. I did this search: https://github.com/search?q=org%3Aunity-sds+cs%2Faccount%2Fnetwork&type=code because we are changing /unity/cs/account/network/subnet_list /unity/cs/account/network/vpc_id to /unity/account/network/subnet_list /unity/account/network/vpc_id

I'm just covering all bases by making this PR. I will be creating some other PRs on the unity-sps repo soon, as well

drewm-jpl commented 2 months ago

Ok, thanks Galen. I'll check with @mike-gangl. I'm just unsure why old SPS terraform is currently duplicated in this repo.

galenatjpl commented 2 months ago

@drewm-jpl @mike-gangl , let's just go ahead and approve and merge in. Regardless of why this is here, I think we should just make it consistent.

drewm-jpl commented 2 months ago

Ok, we can do that if you would like. The SPS terraform that is duplicated in this repo is already extremely out of date with what is in unity-sps. Can you add me as a reviewer then I can approve and merge? Mike may have to add me as a collaborator on this repo for me to be able to approve and merge.

drewm-jpl commented 2 months ago

I have permissions to approve but not to merge.

galenatjpl commented 2 months ago

thanks @drewm-jpl . I added a few reviewers that have write permissions, which should do the trick.