search

unity-sds / unity-monorepo

Apache License 2.0
0 stars 0 forks source link

Update monorepo app-package-service for unity-app-generator version parameters #37

Open mcduffie opened 2 weeks ago

mcduffie commented 2 weeks ago

They could really use a description. Are those requests in the body? Or are they in the header? The clone url was formerly in the header- did that change? If so, that’s a breaking change from work we’ve already done.

Essentially what you should do when developing the API is aslo develop the unity-sds-client module to call it and ensure that’s all working. The way this should work moving forward is as follows:

Update the Schema Generate the new client libraries (instructions are in the schema README) Issue a PR and get it reviewed for merge Once merged, a new apgs-unity-client-library will be published to pypi

update unity_sds_client Add Tests Update version and CHANGELOG info Issue a PR Once merged, a new unity-sds-client will be available in pypi with the updated version

This is “done done” in terms of a functionality within the unity system.

mcduffie commented 1 week ago

Edwin will push changes that fix broken unit tests in the PR.