unity-sds / unity-project-management

Container repo for project management (projects, epics, etc)
Apache License 2.0
0 stars 1 forks source link

STAC Data Keys update #109

Closed mike-gangl closed 1 month ago

mike-gangl commented 5 months ago

STAC Data Keys Updates

Currently we use STAC asset keys of "data", "metadata" and others. This disallows the usage of multiple "data" types as an asset, which breaks the SBG workflows that contain multiple data workflows.

Acceptance Criteria

Dependencies

Risks

mike-gangl commented 5 months ago

Need to have a discussion with @rtapella and @ngachung on the timing of this release.

GodwinShen commented 5 months ago

@ngachung which work tickets are associated with the acceptance criteria shown below?

GodwinShen commented 5 months ago

@mike-gangl is this something that you would do? If so, I guess we should have a ticket for it if you don't already have one elsewhere: Existing Workflows are updated to use new stage-in/out containers

GodwinShen commented 5 months ago

@rtapella , @anilnatha do we have a ticket for this item yet? "Create validation STAC outputs from unity-py". The work tickets listed here don't immediately look applicable to me, but that could just be my lack of understanding.

rtapella commented 5 months ago

Good question. I am not sure what that means exactly or who would do it. Does it mean testing that this works? (specifically taht tickets 67 and 69 in unity.py work, the first two checkboxes)

GodwinShen commented 5 months ago

@mike-gangl what do we mean by the task "Create validation STAC outputs from unity-py"? I don't know if this is something we need UI/UX to do or what. Can you help clarify this one?

mike-gangl commented 5 months ago

Open question- how can we inform U-DS which file is the stac-json file to read metadat from. Consider the case where we have multiple metadata file ending with .json?

data_file.tiff (role: data)
data_file.met.json (role: metadata)
data_file.json (role: metadata, stac, u-ds needs this one)
data_file.mdf (role: metadata)
data_file.png (role: browse)

I wonder if we should call the file data_file.stac.json so we have a good indication of what to key off of? in this case, we can set the cumulus configuration to look for *.stac.json files

@ngachung thoughts?

ngachung commented 5 months ago

We can standardize on data_file.stac.json, but for now our implementation as described in https://github.com/unity-sds/unity-data-services/issues/301 is to parse all the json files until we get a valid stac feature.

mike-gangl commented 5 months ago

@GodwinShen - regarding "Validation Outputs" means to work with U-DS to ensure the output files from to_stac() are valid from the U-DS perspective. This is for stage-out and the ingestion portions of stac.

rtapella commented 1 month ago

marked Done but never Closed