search

unity-sds / unity-py

Apache License 2.0
2 stars 3 forks source link

Features/update asset roles #73

Closed anilnatha closed 8 months ago

anilnatha commented 8 months ago

Purpose

Updated dataset asset lists so that we now use the URI/HREF of the asset as the key in the list the assets. The role/type of the data (e.g. "metadata", "data", etc.) is now an attribute of the asset with a key of "roles".

Proposed Changes

coveralls commented 8 months ago

Coverage Status

coverage: 85.912% (+0.2%) from 85.749% when pulling e31fbd5761ac180604d7aa7d1f692ba1dd9316be on features/update-asset-roles into 1c0654691b2de7aa8ec94362a04fbda57e3ada8e on develop.

anilnatha commented 8 months ago

Hey @mike-gangl I've made the necessary updates, and tested using both the unit tests (all passed) and the 5_working_with_chirp_data.ipynb tutorial notebook. please review at your earliest.

I was being cautious with trying not to conflate the role and type information. The changes I've made work for CMR presently, and my hope is that they will also work if/when changes are made to CMR to adopt the usage of role information in the same manner that we will be using it with stac.

The information you provided through this effort really helped me better understand our usage of Collections, datasets, and datafiles. 👍🏽

anilnatha commented 8 months ago

Oh and the checks on Github are failing because calls to SPS are returning a status of 500. will need to look into why that is happening.