search

unity-sds / unity-py

Apache License 2.0
2 stars 4 forks source link

Add health service #90

Closed anilnatha closed 2 weeks ago

anilnatha commented 1 month ago

Purpose

Initial implementation of a health service to convey the health state of the system. This implementation is using a stubbed in set of data until we can integrate an API call to fetch the health data for a given project/venue when the API endpoint is implemented.

Proposed Changes

anilnatha commented 1 month ago

Thanks @rtapella, yup, I'm working on the linting right now.

anilnatha commented 1 month ago

@mike-gangl I fixed the linting errors that were being reported in the checks; however, now we're having an issue with coveralls and all it reports is:

🔍 Detected coverage file: .coverage
🚨 Nothing to report
Error: Process completed with exit code 1.

Have you come across this issue in the past?

coveralls commented 2 weeks ago

Coverage Status

coverage: 52.801% (-34.8%) from 87.575% when pulling c14bce09f6e08d1e3c1ee6af17dbe7f60d450966 on feature/add-health-service into 44488b0de87acf59273c4eb5d1aaa4d33c60dcee on develop.

coveralls commented 2 weeks ago

Coverage Status

coverage: 52.801% (-34.8%) from 87.575% when pulling d2b62759a23fe14978866ff404c872cfaacfc2da on feature/add-health-service into 44488b0de87acf59273c4eb5d1aaa4d33c60dcee on develop.

mike-gangl commented 2 weeks ago

not sure why the coverage dropped to 50%, but that's something we'll want to increase coverage on in the future.

mike-gangl commented 2 weeks ago

You're free to merge this check in now. i had to update the version of the coverage, but also change the coverage report being generated by pytest. ther was something "under the good" that was causing the coverage formatting to be invalid.

coveralls commented 2 weeks ago

Coverage Status

coverage: 52.801% (-34.8%) from 87.575% when pulling b37a45b454e7a34eb7a94e5c4188a013ab342b74 on feature/add-health-service into 44488b0de87acf59273c4eb5d1aaa4d33c60dcee on develop.