Open rtapella opened 10 months ago
dockstore depends on : https://github.com/unity-sds/unity-ads-deployment/issues/135
relates to "figure out CORS stuff" https://github.com/unity-sds/unity-ui/issues/6
@mcduffie what info do you need from us to configure Dockstore / Jupyter to be happy with CORS requests from the navbar UI to Dockstore and Jupyter?
Can we read the locations of each app from SSM?
Putting this into 24.2 along with the Jupyter -> Marketplace work
For Jupyterhub, this depends on https://github.com/unity-sds/unity-project-management/issues/90
@rtapella is there anything that you and Anil can do ahead of James' MC deployment? Seems to me that it could still be integrated into the Navbar without the MC-method for deployment, @mcduffie and @edwinsarkissian already have Dockstore and Jupyterhub deployments working in some of the venues, can we just hook up to those venues in the mean-time to demonstrate this is working in the Navbar?
We are expecting that when all the apps are deployed via marketplace, they will have the new domain-name address. This “should” resolve the CORS issue. Until then we cannot verify that it will “just work” out of the box.
(We have tried pointing at the dev URLs and we get CORS issues blocking the frame)
Jupyter is at: https://www.dev.mdps.mcp.nasa.gov:4443/unity/dev/jupyter
It should help with the CORS issues
@mcduffie is there a known URL for Dockstore as well?
Are both Dockstore and Jupyter sending status & landing page to the health system?
@mcduffie what authentication is Dockstore using at this point? is it also Cognito or still Github/other?
Still Github.com
@anilnatha so what happens if we have multiple auth systems supporting the iframe'd apps? Or do we need some sort of config for each app to understand the authorization?
@mcduffie we will need the jupyter & dockstore health-endpoint URLs to have the MCP URL then it should show up in the navbar and work properly
@rtapella I need to have a proxying that actually works before I can give you an appropriate URL. Once the proxying is fixed I can be sure the URL wont change.
https://www.test.mdps.mcp.nasa.gov:4443/unity/test/jupyter/
@anilnatha please hard-code this for now so that we can try it out: https://www.dev.mdps.mcp.nasa.gov:4443/unity/dev/jupyter/
Jupyter needs to be hooked up to the health_endpoint
Same with Dockstore
CORS updates so we can display Dockstore and Jupyter with the common navbar on top