search

unity-sds / unity-ui

Apache License 2.0
0 stars 0 forks source link

Get Airflow working inside Navbar #22

Open rtapella opened 9 months ago

rtapella commented 8 months ago

@LucaCinquini what info do you need from us to configure Airflow to be happy with CORS requests from the navbar UI to Airflow?

Can we read the location from SSM?

LucaCinquini commented 8 months ago

Yes, the location is in SSM and @drewm-jpl can tell you which is the parameter to use. But I think the UI/UX team should try to include it in the NavBar and see what problems arise. As I mentioned earlier, I am not sure it is such a great idea to imprison Airflow within another site...

drewm-jpl commented 8 months ago

To find the Airflow UI URL in a given venue, you can find it in an SSM parameter under this naming convention /unity/dev/sps/${DEPLOYMENT_NAME}/${DEPLOYMENT_COUNTER}/processing/airflow/ui_url

anilnatha commented 7 months ago

@drewm-jpl My understanding of the param names is that it should follow something like /unity/{project}/{venue}/... but in that path you've shared, dev is hard coded into the SSM Param.

drewm-jpl commented 7 months ago

@anilnatha Whoops, yes that's correct the venue is parameterized in the SSM parameter name as well.

/unity/{venue}/sps/${DEPLOYMENT_NAME}/${DEPLOYMENT_COUNTER}/processing/airflow/ui_url

Currently, project and venue are combined so the SBG dev SSM parameter would appear like this: /unity/sbg-dev/sps/${DEPLOYMENT_NAME}/${DEPLOYMENT_COUNTER}/processing/airflow/ui_url

There doesn't appear to be guidance on the gitbook docs on how to handle the project/venue combo but that's what we have currently.

anilnatha commented 7 months ago

@drewm-jpl Thanks for the clarification and addressing my concern.

@galenatjpl Could you please point us to the documentation on how to handle the SSM param naming convention with regards to project and venue. IIRC, it was something like /unity/{project}/{venue}/... but I want to make sure this is accurate.

galenatjpl commented 7 months ago

@anilnatha I think we are now settling on /unity/{project}/{venue}/.. (see the "Name Form" section here: https://unity-sds.gitbook.io/docs/developer-docs/common-services/docs/users-guide/deployment/deployment-concepts-and-infrastructure/unity-ssm-parameters/ssm-parameter-naming-requirements-and-conventions).
I think at a minimum we need to stick with the /unity/{project}/{venue}/.. convention, so that proj/venue deployments will know what params explicitly apply to them.

rtapella commented 6 months ago

@anilnatha please work with @drewm-jpl to update this (e.g. use the health json landingPage URL?) or otherwise get a URL to try out to test this... (assuming the CORS stuff will work)

GodwinShen commented 6 months ago

@anilnatha and @rtapella ping for status. Is this still blocked?

rtapella commented 6 months ago

Once Airflow is deployed with the new URL structure, we can test this out—that will/should avoid CORS issues. Initially we'll just use the URL from the Health Status info for each app.

rtapella commented 3 months ago

@LucaCinquini @drewm-jpl we will need the Airflow health-endpoint URLs to have the MCP URL then it should show up in the navbar and work properly