search

unity3d-jp / MeshSync

A package for synchronizing meshes/models editing in DCC tools into Unity in real time.
Other
1.55k stars 174 forks source link

Instance rendering #642

Closed seandillon92 closed 2 years ago

unity-cla-assistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

sindharta commented 2 years ago

Code looks good. Two things to check though

  1. There seems to be a problem with the linux so file. Please check failed Yamato tests
  2. Did you use Mac M1 to build the Mac bundle ? We need to check if the Mac bundle works with Unity 2021.x M1 version, and unfortunately we don't have Yamato test for this yet.
seandillon92 commented 2 years ago

Code looks good. Two things to check though

  1. There seems to be a problem with the linux so file. Please check failed Yamato tests
  2. Did you use Mac M1 to build the Mac bundle ? We need to check if the Mac bundle works with Unity 2021.x M1 version, and unfortunately we don't have Yamato test for this yet.

I have a MBP 2017 so I don't think it would work, could you maybe generate the builds for these platforms?

sindharta commented 2 years ago

I have a MBP 2017 so I don't think it would work, could you maybe generate the builds for these platforms?

ok