search

unity3d-jp / MeshSync

A package for synchronizing meshes/models editing in DCC tools into Unity in real time.
Other
1.55k stars 174 forks source link

fix: make all object types (incl. lights) instantiable for geometry nodes #770

Closed schinkowski closed 1 year ago

sindharta commented 1 year ago

Is it correct that this PR contains changes to

  1. Handle light instances
  2. Control the instances through the parent transform.

If so, it would be great if we can separate those. As @seandillon92 also mentioned, we should also update the docs.

Looks good, we should update the docs to reflect that the instances are now controlled through the parent transform. Do you plan to create another PR for this?

schinkowski commented 1 year ago

Needs this https://github.com/Unity-Technologies/MeshSyncDCCPlugins/pull/255

sindharta commented 1 year ago

@schinkowski Could you please reply to @seandillon92 and my comments above ?

schinkowski commented 1 year ago

Looks good, we should update the docs to reflect that the instances are now controlled through the parent transform. Do you plan to create another PR for this?

I've added it to the docs.

seandillon92 commented 1 year ago

Looks good, we should update the docs to reflect that the instances are now controlled through the parent transform. Do you plan to create another PR for this?

I've added it to the docs.

What about the geometry nodes page? https://docs.unity3d.com/Packages/com.unity.meshsync@0.15/manual/GeometryNodes.html#controlling-instances

sindharta commented 1 year ago

What about the geometry nodes page? https://docs.unity3d.com/Packages/com.unity.meshsync@0.15/manual/GeometryNodes.html#controlling-instances

@schinkowski Can you please address @seandillon92's comment above ?

Also, for the purpose of creating a comment for the squash merge, can you confirm that this PR is for:

  1. Handling light instances
  2. Controlling the instances through the parent transform. ?
schinkowski commented 1 year ago

The purpose of this PR is to: