search

unity3d-jp / MeshSync

A package for synchronizing meshes/models editing in DCC tools into Unity in real time.
Other
1.55k stars 174 forks source link

fix: parallax slider set to min value when using BiRP or URP #893

Closed seandillon92 closed 1 year ago

seandillon92 commented 1 year ago

Parallax fix for server. At the moment, we don't clamp the parallax value, and the values we might be getting from dcc tools make no sense for BiRP and URP.

I set the value to the min possible as in some cases, the parallax effect can cause bleed-in artifacts: BleedingArtifact

sindharta-tanuwijaya commented 1 year ago

One last thing to confirm before merging. I didn't see any code that checks of this is only for URP and Built-In. Is this really the case, or do we need to update the PR header ?

seandillon92 commented 1 year ago

One last thing to confirm before merging. I didn't see any code that checks of this is only for URP and Built-In. Is this really the case, or do we need to update the PR header ?

The code that applies the material data properties is checking if the keyword is used in the material and skips it if not. Since BiRP and URP are using the "_Parallax" keyword and HDRP does not, there is no need to check the rendering pipeline.