search

unity3d-jp / MeshSync

A package for synchronizing meshes/models editing in DCC tools into Unity in real time.
Other
1.55k stars 174 forks source link

feat: add IsLiveEditing API #904

Closed schinkowski closed 1 year ago

schinkowski commented 1 year ago

Adding a way to check whether live editing is active. Need to merge this first: https://github.com/unity3d-jp/MeshSync/pull/903

sindharta-tanuwijaya commented 1 year ago

I think we can merge this API addition to dev (without the spline fixes). Can you please rebase this against dev ?

sindharta-tanuwijaya commented 1 year ago

@schinkowski I see the spline fixes is mixed together in this PR. If we can separate the IsLiveEditing API from it, then it will be possible for us to create a minor release that includes it.

schinkowski commented 1 year ago

Adding a way to check whether live editing is active.

The other PRs were merged into the wrong branch. I made a new PR for this here: https://github.com/unity3d-jp/MeshSync/pull/908

sindharta-tanuwijaya commented 1 year ago

I think we can close this PR since

  1. IsLiveEditing API changes have been merged
  2. There is another PR for spline fixes.

What do you think ? @schinkowski

schinkowski commented 1 year ago

I think we can close this PR since

  1. IsLiveEditing API changes have been merged
  2. There is another PR for spline fixes.

What do you think ? @schinkowski

I guess so, looks like this doesn't have any other changes now.