[For 0.18.x] fix: Instancing fixes

unity3d-jp / MeshSync

A package for synchronizing meshes/models editing in DCC tools into Unity in real time.

Other

1.55k stars 174 forks source link

[For 0.18.x] fix: Instancing fixes #921

Closed schinkowski closed 8 months ago

schinkowski commented 11 months ago

We had an architectural problem with the way we send instances, which this PR addresses. Previously we sent one instance info for each instance, which caused problems when the same object is instanced on multiple parents. With these changes each instance has a collection of parents it appears on, which allows us to parent the instances to the correct parent and allows us to do nested instances correctly.

sindharta-tanuwijaya commented 11 months ago

Can you elaborate what kind of particular bug that this PR fixes ?

schinkowski commented 11 months ago

Can you elaborate what kind of particular bug that this PR fixes ?

Can you elaborate what kind of particular bug that this PR fixes ?

I updated the description.