search

unitycatalog / unitycatalog-ui

Unity Catalog UI
Apache License 2.0
39 stars 14 forks source link

remove all onSuccessCallback params #62

Closed jamieknight-db closed 3 months ago

jamieknight-db commented 3 months ago

Removing all onSuccessCallback parameters in hooks, they are not needed and can be handled in mutation onSuccess instead.

jamieknight-db commented 3 months ago

@xx-db please review when you have a moment

jamieknight-db commented 3 months ago

Thanks!

Assuming you already manually tested those

@yc-shawn yes they have been tested and working as expected

jamieknight-db commented 3 months ago

Looks nice, can you double check the invalidations are working properly?

@Romanize everything is working as it was before, but I noticed the tree view browser is not updating after any of the invalidateQueries (which was an existing issue). It's bothering me so I am looking into a fix.

jamieknight-db commented 3 months ago

Going to merge this and circle back to the issue of refreshing the tree view. I haven't been able to find a solution.