search

unitycatalog / unitycatalog-ui

Unity Catalog UI
Apache License 2.0
39 stars 14 forks source link

fix schema browser not subscribing to query client #64

Closed xx-db closed 2 months ago

xx-db commented 3 months ago

THANK YOU @xx-db this was driving me nuts yesterday, I had to step away 😵‍💫 was the main fix to move the queryClient out of the AppProvider?

haha it was bugging me too. Yes the main fix is to move the queryClient out, this one is just hard to debug but the fix is pretty straightforward. The other changes just made it cleaner. We don't have to include those if there are strong opinions.

jamieknight-db commented 3 months ago

THANK YOU @xx-db this was driving me nuts yesterday, I had to step away 😵‍💫 was the main fix to move the queryClient out of the AppProvider?

haha it was bugging me too. Yes the main fix is to move the queryClient out, this one is just hard to debug but the fix is pretty straightforward. The other changes just made it cleaner. We don't have to include those if there are strong opinions.

The inconsistency was my hurdle, the tree view would update sometimes but mostly not. All the changes look good to me - thanks again!