unitycatalog / unitycatalog

Open, Multi-modal Catalog for Data & AI
https://unitycatalog.io/
Apache License 2.0
2.44k stars 393 forks source link

SLF4J Warnings showing up when starting the UC Server in CLI #269

Closed vksx closed 3 months ago

vksx commented 4 months ago

Describe the bug

Getting the following SLF4J warnings when starting the UC Server:

To Reproduce

Steps to reproduce the behavior:

  1. build/sbt package
  2. bin/start-uc-server

Expected behavior

We should get rid of these warnings.

System [please complete the following information]:

Additional context

As mentioned here we can get rid of the warnings if we replace log4j-slf4j-impl with log4j-slf4j2-impl in build.sbt here and here.

Please let me know if this makes sense. Thanks!

jaceklaskowski commented 4 months ago

Apache Spark and Delta Lake use slf4j for logging and am wondering why UC chose another lib? Perhaps UC could (should?) use the same logging lib?

jaceklaskowski commented 4 months ago

The following should work in commonSettings:

  libraryDependencies ++= Seq(
    "org.slf4j" % "slf4j-api" % "2.0.13",
    "org.slf4j" % "slf4j-log4j12" % "2.0.13" % Test,
    "org.apache.logging.log4j" % "log4j-slf4j2-impl" % "2.23.1",
    "org.apache.logging.log4j" % "log4j-api" % "2.23.1",
  ),

Let me know @vksx if you wanna work on it. I can support you if needed.

vksx commented 4 months ago

@jaceklaskowski Sure, I'll take this up. I will add the recommended changes to commonSettings.