search

unitycoder / UnityLauncher

Unity Version Launcher
MIT License
138 stars 28 forks source link

Some typing errors in strings (Form1.cs) #48

Closed hexenwerkgames closed 6 years ago

hexenwerkgames commented 6 years ago

I've found some typing errors in strings in Form1.cs

I'm not so familiar with github yet, but I started a pull request and hope this works. :)

unitycoder commented 6 years ago

for some reason it shows the whole file as changed (every line).. so i'm not sure what was changed..

looks like this issue, https://stackoverflow.com/questions/19593909/git-diff-sees-whole-file-as-changed-when-its-not

are you using commandline git, or sourcetree, github desktop?

hexenwerkgames commented 6 years ago

Oh, I see ... my fault, I just uploaded the single file manually via browser. I guess that (maybe) only works for new files. I closed the pull request and I will see if it helps to use one of the tools you mentioned.

hexenwerkgames commented 6 years ago

Looks like the second try worked. What I haven't found in the files were e.g. the names of the tabs. Maybe you'd like to change "Unity's" to "Unitys" or "Unity Versions" and in Settings: "Explorer context menu: Install / Uninstall" (consistency) and "Check for Updates" ?

Yeah ... nitpicking by a non-coder. :)

unitycoder commented 6 years ago

ok, looks fine now thanks! (ill merge it sometime this week and check those titles)

unitycoder commented 6 years ago

this is now live, https://github.com/unitycoder/UnityLauncher/releases