unitycontainer / aspnet-mvc

ASP.NET MVC 5 Adapter
Apache License 2.0
13 stars 10 forks source link

Refactoring and fixes. #3

Closed axelgenus closed 7 years ago

axelgenus commented 7 years ago

Here is what I changed:

ENikS commented 7 years ago

Sorry but I have to insist on keeping these as is. If we change name of the package it will no longer show up as an upgrade to Unity.Mvc. We are not creating a new package, we slightly upgrade the old one so let's stick with historic names and preserve the legacy :)

axelgenus commented 7 years ago

Ok, I will revert the package renaming.

ENikS commented 7 years ago

Just get the fresh one from repo. You have stale project files which create conflicts when merging.

axelgenus commented 7 years ago

I will keep the package name the same and align at least the namespaces.

PS: do you use any kind of collaboration tool like slack? It would be useful to exchange opinions...

ENikS commented 7 years ago

You will make ReSharper and early adopters very unhappy. If you not using ReSharper, I'd suggest you do. They offer free license for Open Source contributors.

Actually, I am not opposed to it, just want to keep it in the green with ReSharper.

I can't access any of these. GitHub is the best option for me.

axelgenus commented 7 years ago

My ReSharper is always happy... ;)

For namespace's checks it uses RootNamespace and not PackageId.

ENikS commented 7 years ago

Well, as long as you writing release note explaining the rationale for the change and deal with angry early adopters, I am fine with it :)

axelgenus commented 7 years ago

Deal. ;)