unitycontainer / aspnet-webapi

Unity.AspNet.WebApi package
Apache License 2.0
9 stars 11 forks source link

My project is aspnet-webapi, the project needs upgrading to.Net Core, but you only support net47, net46 and net45, can.Net Core Support? #11

Closed ghd258 closed 6 years ago

ghd258 commented 6 years ago

My project is aspnet-webapi, the project needs upgrading to.Net Core, but you only support net47, net46 and net45, can.Net Core Support?

ENikS commented 6 years ago

@Chavoshi Would you be interested to help with this one as well?

Chavoshi commented 6 years ago

Hi @ENikS, It's my pleasure to help.

ghd258 commented 6 years ago

https://github.com/unitycontainer/aspnet-mvc too net core support

ghd258 commented 6 years ago

@ENikS https://github.com/unitycontainer/aspnet-mvc too net core support Would you be interested to help with this one as well?

ghd258 commented 6 years ago

@Chavoshi @ENikS When is this a good problem?

ENikS commented 6 years ago

Do you want to do it yourself and send a PR?

Chavoshi commented 6 years ago

I tried to do the changes, but really it's not a simple job as DependencyResolver deprecated in ASP.NET Core and we need to implement them as ServiceProvider. I researched on this concept as well but it is not something overnight which we can put them in, as personally still there are a lot of blurry parts for me.

So in conclusion, in my opinion, this change is not a simple conversion and it needs to think more deeply and in addition it might need some infrastructural changes in core as well.

ghd258 commented 6 years ago

Thank you very much. If this is the case, I will give up using this component.

Chavoshi commented 6 years ago

Hi @ghd258, Please take a look at this package: https://github.com/unitycontainer/microsoft-dependency-injection I believe for .Net Core 2.0, you do not need to use aspnet-webapi and aspnet-mvc packages at all.