search

unitycontainer / microsoft-logging

Adapter for Microsoft.Extensions.Logging
Apache License 2.0
16 stars 6 forks source link

Register ILoggerFactory #5

Closed OskarKlintrot closed 5 years ago

OskarKlintrot commented 5 years ago

I noticed that the extension doesn't register ILoggerFactory despite that Microsoft's documentation says that it's a valid use case to inject the factory to be able to explicitly specify the log category. Maybe the instance of the factory could be registered as well?

ENikS commented 5 years ago

It is a good suggestion. Would you like to send a pull request?

OskarKlintrot commented 5 years ago

I could give it a try! What would make sense to (unit) test? Only that it can get resolved or something else?

ENikS commented 5 years ago

I think getting the factory should be sufficient