search

unitycontainer / registration-by-convention

Unity.RegistrationByConvention package (Requires Core Implementation. Any contributors?)
Apache License 2.0
4 stars 12 forks source link

WIP: Net standard #7

Closed PolitovArtyom closed 5 years ago

PolitovArtyom commented 5 years ago

How about this?

For .Net standard 1.0 support we should remove DuplicateTypeMappingException. And it will break backward compatibility.,

ENikS commented 5 years ago

Why don't you conditionally provide this exception for Netstandard 1.0? Just cut and paste implementation and include it just for that platform.

yfital commented 5 years ago

Hey @danrien,

Do we have an ETA for the merge request? the package contains a lot of static functions which are very handy

I don't think netstnd1.x should be blocking here, support can be added later. If there is any help / testing needed before merging, i'll be happy to help

PolitovArtyom commented 5 years ago

@ENikS As i know, netstandard 1.0 has no support for serializable attribute. So there are no safe way to use custom exceptions in nuget packages due to problems while working with cross-domain applications.

ENikS commented 5 years ago

Thank you for PR, I've deployed new package. Feel free to send more of these...