unitystation / unitystation

The original unitystation
https://unitystation.org
GNU Affero General Public License v3.0
703 stars 647 forks source link

Anomaly Reports #10320

Closed AtnerNT closed 1 month ago

AtnerNT commented 1 month ago

This PR refactors the existing artifact data disk system to use pen and paper reports.

Currently, the old system works as follows: Science contains an artifact data disk item. This item is inserted into the artifact console. Observations about the artifact are recorded on the console and then uploaded onto the disk. The disk is ejected when ready, and can be sold at cargo. The more accurate the data on the disk, the more valuable it is, up to 10,000 credits for a 100% accurate report.

How this PR changes this: The data disk item and accompaning box of data disk have been removed from the game. Instead, after observations are recorded in the console, the console will print a paper report of the observations. This paper can be sold at cargo the same way as the data disk can be. Difference being, this report is not a special item and is simply paper with text on it. This report can be read, so players can now view the observations on the report unlike before, also players can edit the contents of reports. Reports can be photocopied, filed, and all other features that accompany paper. Any piece of paper formatted correctly can be sold as a report.

The purpose of this change is to: A) Reduce the amount of unnecessary items in the game. B) Allow players to review and edit research data after uploading. C) Support roleplay and further bureaucracy gameplay.

See #progress-media for pictures

Changelog:

CL: [New] Artifact data disks have been removed. Anomaly research data is now printed on pen and paper reports that can be edited and reviewed at players pleasure. This reports retain their ability to be sold at cargo. CL: [Balance] While lavaland remains easy, accessible and a better option than asteroids. Anomaly Reports now sell for 12,500 credits instead of 10,000 CL: [Balance] Unresearched Artifact Crates may be purchased from cargo for 10,000 credits for one. This is not a very monetarily profitable option for stations, but maintains a way for science to keep a steady stream of artifacts on rounds where cargo does not have the man power to send miners on asteroid expeditions. CL: [Improvement] The artifact research console has been renamed the Anomaly Reporting Console and has received a new look and features to accommodate the data disk changes. CL: [Fix] Fixed the issue in which photocopier trays could not be loaded by clients. CL: [Fix] Fixed the issue in which photocopier trays and scanners could both be open simultaneously, leading to confusing interactions. CL: [Fix] Fixed radioactive artifacts emitting the wrong colour light.

AtnerNT commented 1 month ago

Scene changes are removing the now missing datadisk prefabs, all stations with xenoarch mapped needed to be changed

AtnerNT commented 1 month ago

This PR should also close #9980. Have tested on LocalHost with two clients and the bug seems to be resolved. Though probably best to also test on staging before closing.

AtnerNT commented 1 month ago

Fixed important codacy issues. Tests will continue to fail because of code scan, scan whitelist is updated in this PR but obviosuly wont take effect until after it is merged