unitystation / unitystation

The original unitystation
https://unitystation.org
GNU Affero General Public License v3.0
703 stars 647 forks source link

Make switching on lights more visually pleasing #10329

Closed MaxIsJoe closed 1 month ago

MaxIsJoe commented 1 month ago

CL: [Improvement] There is a small delay on light switches affecting its connected light bulbs, making them more visually pleasing when turning on/off.

Bod9001 commented 1 month ago

What about loss of power?

MaxIsJoe commented 1 month ago

What about loss of power?

there isn't even anything remotely in this PR that changes how power stuff is handled

light source handles that, we don't change anything about it

Bod9001 commented 1 month ago

I think light switches get turned off when power goes off

Bod9001 commented 1 month ago

also did you check that the state of the lights aren't synchronised already, since you added a hook on the synchronisation of the light switch

MaxIsJoe commented 1 month ago

I literally did not change anything, I just added a delay to the invocation

MaxIsJoe commented 1 month ago

image

MaxIsJoe commented 1 month ago

since you added a hook on the synchronisation of the light switch

where in this PR did I add a syncvar, or any networking related changes.

Bod9001 commented 1 month ago

ok, still the issue with light switches though, powering off

MaxIsJoe commented 1 month ago

ok, still the issue with light switches though, powering off

If it was an issue, we would have noticed it long before I made this change.