unitystation / unitystation

The original unitystation
https://unitystation.org
GNU Affero General Public License v3.0
710 stars 633 forks source link

many issues with heat transfer pipes #7490

Open Leander-0 opened 3 years ago

Leander-0 commented 3 years ago

Environment

Detailed description of bug

Basically the heat transfer pipes kinda work but not fully maybe because the actual heat transfer isnt implemented or because it broke along the way.

first off the sprite of the connectors invert when wrenched down:

https://user-images.githubusercontent.com/80334192/135375535-a81b518b-413b-4a6a-ab99-783dac2093e4.mp4

second, the heat transfer doesn't happen

In this example i made a custom gas loop that constantly flows gas across the loop and in theory the gas that moves trough the space cooled heat transfer pipes should be getting colder but it doesn't, i even added extra gas that was slightly hotter than the one in the loop and it heated up the gas but that was no cooling at all afterwards.

https://user-images.githubusercontent.com/80334192/135375874-11ba1c1f-5c12-4212-b8b3-d682e4658c58.mp4

also the pipes are slightly misaligned, terrible. pipes

Steps to reproduce

  1. make a custom loop and connect it to heat transfer pipes in space
  2. have fun with atmos

NOTE: heating the heat transfer pipes in a combustion chamber to transfer its heat hasn't been tested.

Bod9001 commented 3 years ago

I think the code is commented out for them