search

unitystation / unitystation

The original unitystation
https://unitystation.org
GNU Affero General Public License v3.0
704 stars 648 forks source link

You can now pull tails #8065

Closed MaxIsJoe closed 2 years ago

MaxIsJoe commented 2 years ago

A very important parity feature from /tg/ that unitystation cannot survive without

CL: [New] you can now pull tails.

corp-0 commented 2 years ago

I know this PR is somewhat of a meme but still, I don't think it makes much sense. Having a chance to gib someone by simply spamming a click isn't fun, and that aside pulling creatures tails isn't a cool experience for the tail owner, equiparable with a hug.

wraith-54321 commented 2 years ago

does this gib the person doing the pulling or the person who is having their tail pulled

corp-0 commented 2 years ago

does this gib the person doing the pulling or the person who is having their tail pulled

it was the performer, my bad. The rest of my points still stand.

MaxIsJoe commented 2 years ago

I know this PR is somewhat of a meme but still, I don't think it makes much sense. Having a chance to gib someone by simply spamming a click isn't fun, and that aside pulling creatures tails isn't a cool experience for the tail owner, equiparable with a hug.

Then why does SS13 has a gib on fart on bible interaction? It doesn't need to make sense; it's fun and that's it and unlike the instant fart gib this has a 0.4 chance of happening; meaning that you'll only get yourself killed if you want to suicide.

AtnerNT commented 2 years ago

Maybe atleast add a min amount of tries before you have a chance to gib. (Like 5-10 tail pulls). Because due to the nature of random chance, it may so happen someone logs in, is having a really fun round, pulls one persons tail and they are dead. Its a very low chance yes but it will still ruin rounds for quite a few people or atleast feel very bs. I feel like the chance to gib should only be relevant for people trying to get gibbed. (Or maybe make it, it only has a chance to gib if the player does it multiple times within a given time frame, like if they pull a tail more then 2 times in a minute)

MaxIsJoe commented 2 years ago

Maybe atleast add a min amount of tries before you have a chance to gib. (Like 5-10 tail pulls). Because due to the nature of random chance, it may so happen someone logs in, is having a really fun round, pulls one persons tail and they are dead. Its a very low chance yes but it will still ruin rounds for quite a few people or atleast feel very bs. I feel like the chance to gib should only be relevant for people trying to get gibbed. (Or maybe make it, it only has a chance to gib if the player does it multiple times within a given time frame, like if they pull a tail more then 2 times in a minute)

Sounds like a good idea

PerfectTangent commented 2 years ago

I know this PR is somewhat of a meme but still, I don't think it makes much sense. Having a chance to gib someone by simply spamming a click isn't fun, and that aside pulling creatures tails isn't a cool experience for the tail owner, equiparable with a hug.

I don't think it's that big of a deal. there is quite a collection of other gimmicky easter eggs like this in ss13. It's a risk you opt into that can rarely have funny results. that's good clown content. This implementation is also at least 50% less degenerate than /tg/ because there's no I love getting my tail pulled! message.

This codebase is quickly approaching safety goggles territory, though.

PerfectTangent commented 2 years ago

I feel like the chance to gib should only be relevant for people trying to get gibbed. (Or maybe make it, it only has a chance to gib if the player does it multiple times within a given time frame, like if they pull a tail more then 2 times in a minute)

I like this suggestion. make it something you spam to explode.

MaxIsJoe commented 2 years ago

This codebase is quickly approaching safety goggles territory, though.

Until we have moods, quirks and more race uniqueness in terms of functionality and intractability; I think we're fine.

Cboyjet4 commented 2 years ago

What is the point of this

Cboyjet4 commented 2 years ago

I know this PR is somewhat of a meme but still, I don't think it makes much sense. Having a chance to gib someone by simply spamming a click isn't fun, and that aside pulling creatures tails isn't a cool experience for the tail owner, equiparable with a hug.

Then why does SS13 has a gib on fart on bible interaction? It doesn't need to make sense; it's fun and that's it and unlike the instant fart gib this has a 0.4 chance of happening; meaning that you'll only get yourself killed if you want to suicide.

That's funny, this is just weird + that's different since it's nearly completely avoidable if you aren't forced into doing it.

MaxIsJoe commented 2 years ago

What's funnier than the PR itself has been always the reactions and how everyone has been taking this stupid thing that /tg/ added seriously Don't think about this too deeply, it's a funny lil interaction no one will notice unless they go out of their way to find it and with a funny outcome for people who 'engage in indecent conduct'.. But hey; I'm not going to stop you from talking seriously about it until everyone knows about it's existence and I continue having more laughs about how everyone reacts to it ;)

MaxIsJoe commented 2 years ago

Added the cooldown

corp-0 commented 2 years ago

you can use station time for a way simpler cooldown

craftxbox commented 2 years ago

Oh god I thought you were joking about making this a thing...

MaxIsJoe commented 2 years ago

you can use station time for a way simpler cooldown

I feel like creating a new variable to keep track of the last station time and comparing the last two between each hug seems like it complicates it more rather than simplify it. I've also voiced my dislike for this way of checking for anything time related because if we were to ever add something that messes around with the station timer (like a spell that can speedup time or slow it) this would majorly impact the way we check stuff and could potentially break them.

MaxIsJoe commented 2 years ago

Oh god I thought you were joking about making this a thing...

It was and still is a joke

bottom text

MaxIsJoe commented 2 years ago

Everything is done now i think

Cboyjet4 commented 2 years ago

What's funnier than the PR itself has been always the reactions and how everyone has been taking this stupid thing that /tg/ added seriously Don't think about this too deeply, it's a funny lil interaction no one will notice unless they go out of their way to find it and with a funny outcome for people who 'engage in indecent conduct'.. But hey; I'm not going to stop you from talking seriously about it until everyone knows about it's existence and I continue having more laughs about how everyone reacts to it ;)

So, this is a PR just to laugh at people for not wanting this ingame? And then you justify it by "oh it's just a fun little feature forget about it" 😐

MaxIsJoe commented 2 years ago

So, this is a PR just to laugh at people for not wanting this ingame?

No, this PR adds a meme feature from /tg/. It's main source of being funny to me has been always how absurd that it has been merged in the /tg/ codebase of all places and as this PR's title and if I was looking to fish for people's reactions I would have added much more degenerate things to this PR that /tg/ itself didn't add in it's original such as heart particles and more semi-lewd messages. People's reactions to these two PRs just add another level to it being more funny considering that they're taking something they're not going to engage in or use way too seriously than they should and talking about it as if it's a critical feature that should or shouldn't be added to the game.

And then you justify it by "oh it's just a fun little feature forget about it" 😐

I never tried justifying anything and I'd be dumb if I tried justifying a meme PR to people who have strong negative reactions over a clear joke , this isn't twitter so I'm not obligated to justify what I find funny to other people and people can continue feeling uncomfortable/angry over a meme PR with content they'll never touch in their lives, idc.

This is my final say on the matter :

and I'm not going to comment on this anymore after I fix the codacy issues

craftxbox commented 2 years ago

Maybe it would be helpful to convene with gilles/etc about adding some kind of option for a player to allow and/or prevent others from pulling on their tail? I can see some people getting rather annoyed by it regardless of the gib chance. Plus, Possibly some servers may wish to avoid this entirely.

MaxIsJoe commented 2 years ago

Maybe it would be helpful to convene with gilles/etc about adding some kind of option for a player to allow and/or prevent others from pulling on their tail? I can see some people getting rather annoyed by it regardless of the gib chance. Plus, Possibly some servers may wish to avoid this entirely.

How about we add an option to disable farting on bibles because some people might find it offensive? How about we remove species from the game because that allows furry content and some people don't like that and have irrational hatred for anyone that plays a character thats not human? How about we remove every food item that uses meat or milk from animals like cows or Pete because some vegan players will not like that the chef is making non-vegan food in-game?

I'm sorry but no; I'm not going to add an option to disable a single line of text and I don't care how anyone feels about this. /tg/ doesn't have an option to disable it and the world didn't end.

craftxbox commented 2 years ago

There is a difference between something that's obviously a gimmick, and something thats actually an erp thing. Why do you have to be so aggressive?

MaxIsJoe commented 2 years ago

There is a difference between something that's obviously a gimmick, and something thats actually an erp thing. Why do you have to be so aggressive?

I'm not aggressive, I'm simply stating that it doesn't make sense to have an entire server config setting for a single line of text and I'm not going to disable a joke just because some people don't like it. Also how is it a gimmick to be offensive towards religion? How does pulling a tail suddenly mean it's full on ERP? We're going to be arguing forever about this over a meme.

I'm not changing nor adding anything new to this PR except fixing codacy issues.

MaxIsJoe commented 2 years ago

Codacy issues solved