unitystation / unitystation

The original unitystation
https://unitystation.org
GNU Affero General Public License v3.0
704 stars 648 forks source link

Behavior tree addon + namespace core transform enum/type #9008

Closed MaxIsJoe closed 1 year ago

MaxIsJoe commented 1 year ago

Adds a behavior tree addon and puts an enum/type inside a namespace so it doesn't conflict with other similiar names in other unity stuff

corp-0 commented 1 year ago

Did you change anything in the packages files?

NoooneyDude commented 1 year ago

I don't suppose they provide this as a unity package? Does their repo have a package.json?

NoooneyDude commented 1 year ago

Can you link to the source of the asset you're using?

NoooneyDude commented 1 year ago

Maybe there's an alternative we can use that bothers to namespace its scripts?

github-actions[bot] commented 1 year ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

corp-0 commented 1 year ago

Maybe there's an alternative we can use that bothers to namespace its scripts?

it is namespaced, the issue was we didn't namespace ours

NoooneyDude commented 1 year ago

Maybe there's an alternative we can use that bothers to namespace its scripts?

it is namespaced, the issue was we didn't namespace ours

I saw scripts that weren't namespaced though.

MaxIsJoe commented 1 year ago

Did you change anything in the packages files?

Nope

I don't suppose they provide this as a unity package? Does their repo have a package.json?

No, I just imported it directly from the package and it only gave me the files related to it. nothing else.

link?

https://thekiwicoder.com/behaviour-tree-editor/

Maybe there's an alternative we can use that bothers to namespace its scripts?

Actually the addon is namespaced correctly It's out fault for not namespacing our core stuff that gets in the way of unity's own things

I saw scripts that weren't namespaced though.

Which ones? maybe i can namespace them once i open rider again

NoooneyDude commented 1 year ago

Which ones? maybe i can namespace them once i open rider again

were the ones I saw. Might be more. Only checked the first class definition in each file.

Which name was conflicting?

corp-0 commented 1 year ago

Orientation. This PR adds namespace to that enum already.

NoooneyDude commented 1 year ago

Do you know what the license is for it? I couldn't see anything in the link and no license file either.

MaxIsJoe commented 1 year ago

https://www.youtube.com/watch?v=SgrG6uAZDHE&t=5s

corp-0 commented 1 year ago

Which ones? maybe i can namespace them once i open rider again

  • MoveToPosition
  • Breakpoint
  • RandomPosition
  • BehaviourTreeSettings

were the ones I saw. Might be more. Only checked the first class definition in each file.

Which name was conflicting?

looking at the code, it seems mostly everything is properly namespaced but those nodes.

NoooneyDude commented 1 year ago

If the author provided a source repository he might've appreciated a PR to namespace them. Ah well. All good.

Interested to see what we can make with this.

github-actions[bot] commented 1 year ago

Conflicts have been resolved. A maintainer will review the pull request shortly.

MaxIsJoe commented 1 year ago

image

I solved merge conflicts but it seems like i broke something in the process that made it not want to compile, working on it right now

MaxIsJoe commented 1 year ago

yup its done, should work now

MaxIsJoe commented 1 year ago

sorry this took 16 days to finish lol