Closed MaxIsJoe closed 1 year ago
Did you change anything in the packages files?
I don't suppose they provide this as a unity package? Does their repo have a package.json?
Can you link to the source of the asset you're using?
Maybe there's an alternative we can use that bothers to namespace its scripts?
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Maybe there's an alternative we can use that bothers to namespace its scripts?
it is namespaced, the issue was we didn't namespace ours
Maybe there's an alternative we can use that bothers to namespace its scripts?
it is namespaced, the issue was we didn't namespace ours
I saw scripts that weren't namespaced though.
Did you change anything in the packages files?
Nope
I don't suppose they provide this as a unity package? Does their repo have a package.json?
No, I just imported it directly from the package and it only gave me the files related to it. nothing else.
link?
https://thekiwicoder.com/behaviour-tree-editor/
Maybe there's an alternative we can use that bothers to namespace its scripts?
Actually the addon is namespaced correctly It's out fault for not namespacing our core stuff that gets in the way of unity's own things
I saw scripts that weren't namespaced though.
Which ones? maybe i can namespace them once i open rider again
Which ones? maybe i can namespace them once i open rider again
MoveToPosition
Breakpoint
RandomPosition
BehaviourTreeSettings
were the ones I saw. Might be more. Only checked the first class definition in each file.
Which name was conflicting?
Orientation
. This PR adds namespace to that enum already.
Do you know what the license is for it? I couldn't see anything in the link and no license file either.
Which ones? maybe i can namespace them once i open rider again
MoveToPosition
Breakpoint
RandomPosition
BehaviourTreeSettings
were the ones I saw. Might be more. Only checked the first class definition in each file.
Which name was conflicting?
looking at the code, it seems mostly everything is properly namespaced but those nodes.
If the author provided a source repository he might've appreciated a PR to namespace them. Ah well. All good.
Interested to see what we can make with this.
Conflicts have been resolved. A maintainer will review the pull request shortly.
I solved merge conflicts but it seems like i broke something in the process that made it not want to compile, working on it right now
yup its done, should work now
sorry this took 16 days to finish lol
Adds a behavior tree addon and puts an enum/type inside a namespace so it doesn't conflict with other similiar names in other unity stuff