Adding changeling game mode #6155.

[SerheyKr]

Purpose

PR related with #6155 and #9911 - adds changeling game mode and some abilities.

Changelog

CL: [New] Added new game mode and antagonist: Changeling. CL: [Improvement] Improving of #9911 script

[MaxIsJoe]

Please add the changeling antag to the adminJobsList SO file.

[MaxIsJoe]

Intro text is not clearly readable in its current state. Darken the background.

[AtnerNT]

Also Codacy has outlined alot of issues, alot of these are fairly valid so please try and address them.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[MaxIsJoe]

same thing with health, there are a lot of things that can be put in their own components/interfaces since other characters won't use.

also revert the changes you made to the lobby scene.

[MaxIsJoe]

I'm going to approve this once all changeling code has been modularized into their own components/interfaces/extensions to uphold the single responsibility principle.

what will be left is solving merge conflicts and Gillies' / Bod's review, then this PR is good to go 👍

[Bod9001]

any updates on progress?

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Bod9001]

ok, looks good there's a few bits and bobs but some of that is how our code is structured so, only thing that sticks out is putting functionality directly in brain.CS vs inheriting and adding your functionality/adding another class

[corp-0]

I'm trying to build this to give it a live test, but it seems like your branch is outdated. Can you rebase from latest develop?

[corp-0]

Okay. I think it was an issue because of the amount of commits and older commits were conflicting. Let me make the build and we can see live how it goes.

[corp-0]

I will make another build of this PR to see if the issues are fixed. If they aren't, please let's talk about it on the development channel so we get this done sooner.

[github-actions[bot]]

We have the following test results:

PrefabsAreNotAt00Classname: Tests.Scenes.GeneralSceneTests

Methodname: PrefabsAreNotAt00 Result: Failed Failure: Object: "Backrooms/Backrooms/Objects/MaintGenerator (5)" is at 0,0. Please update the prefab/update the map/revert.

Expected: False But was: True

at Tests.Scenes.GeneralSceneTests.PrefabsAreNotAt00 () [0x00107] in /github/workspace/UnityProject/Assets/Tests/Scenes/GeneralSceneTests.cs:45

[corp-0]

did you update to the version of develop that works? So I can build this again and try the changelings again

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

Conflicts have been resolved. A maintainer will review the pull request shortly.