univention / ucs-appliance-container

UCS appliance container image setup
GNU Affero General Public License v3.0
7 stars 5 forks source link

Get smaller images, fix some issues and add new features. #7

Closed GinoHarlos closed 1 year ago

GinoHarlos commented 2 years ago

Please make sure you considered the following things

Link to the issue in Bugzilla

Please scroll to the end ( Live patches are included ).

Description of the changes

Please describe the changes with a few sentences. ( So sorry there are quite a lot of changes and now we have about a year after the first initial commit ... :)

Motivation

Documentation changes

Dockerfile changes

BugFixes

Features

Unanswered questions

Is there more?

diff --git a/base/univention-server/debian/control b/base/univention-server/debian/control
@@ -165,13 +165,21 @@ Description: UCS system server role common dependencies and files
 Package: univention-container-role-server-common
...
+ ntp | ntp-server,
+ ntpdate,
+ python-dns,
...
+ univention-home-mounter,
...
+ univention-maintenance,
+ univention-nfs-server,
+ univention-portal,
+ univention-quota,
...
 Package: univention-container-role-common
...
- univention-docker-container-mode,
+ univention-firewall,
  univention-join,
+ univention-pkgdb-tools,
...

What were and are your test criteria?

  1. univention-check-join-status | grep -E -q "^Joined successfully" && echo SUCCESSFULY
  2. docker run ... --env DEBUG=TRUE ... looks nice and all run-parts are successfuly
  3. systemctl list-units --state failed looks nice after restarting the container once
    test $(
    docker exec ${container} systemctl list-units --state failed --no-pager --no-legend | wc -l
    ) -eq 0 && echo SUCCESSFULY

Is there any fork to test it?

Live patches are included!

GinoHarlos commented 2 years ago

Please be lenient because this is my first pull request. Feel free to give any kind of feedback so that I can improve myself :)

GinoHarlos commented 1 year ago

Get smaller images, fix some issues and add new features ( update )

Please make sure you considered the following things

Link to the issue in Bugzilla

Description of the changes

Please describe the changes with a few sentences.

Motivation

Documentation changes

Dockerfile changes

BugFixes

GinoHarlos commented 1 year ago

Get smaller images, fix some issues and add new features ( fixes )

Please make sure you considered the following things

Link to the issue in Bugzilla

Description of the changes

Please describe the changes with a few sentences.

Motivation

Documentation changes

BugFixes

Known issues

GinoHarlos commented 1 year ago

Get smaller images, fix some issues and add new features ( fixes and defaults )

Please make sure you considered the following things

Link to the issue in Bugzilla

Description of the changes

Please describe the changes with a few sentences.

Motivation

Documentation changes

Known issues

reqa commented 1 year ago

Ok, merged manually (via detour of Univention gitlab).

Updated docker image is uploaded too: https://hub.docker.com/r/univention/univention-corporate-server/tags