universal-ctags / citre

A superior code reading & auto-completion tool with pluggable backends.
GNU General Public License v3.0
326 stars 26 forks source link

Wrong colors of peek window on macOS #106

Open LimingFang opened 2 years ago

LimingFang commented 2 years ago

我先用中文描述一遍,方便更准确的表达问题吧,之后有解决方案了在翻译成英文。

我在emacs app下用citre-peek的时候,window跳出来还比较正常的配色:

image

但是在terminal下配色就比较晃眼,尽管emacs本身配色不错:

image

所以想问下,peek-window配色支持自定义吗

AmaiKinono commented 2 years ago

The colors of the peek window are calculated on the fly to fit the current Emacs theme, so they can't be customized.

I haven't encounter your problem in any of my terminal emulators. Could you try it with another terminal emulator?

masatake commented 2 years ago

The colors of the peek window are calculated on the fly to fit the current Emacs theme, so they can't be customized.

If we can use another theme only for rendering the peek window, it may be impressive. However, I'm not sure it is useful for daily use;-).

LimingFang commented 2 years ago

The colors of the peek window are calculated on the fly to fit the current Emacs theme, so they can't be customized.

I haven't encounter your problem in any of my terminal emulators. Could you try it with another terminal emulator?

Does theme of my terminal emulator influence behavior of "current Emacs theme" ? Does your peek-window look good in emulator? I tried in macos native terminal app and iterm2, but they all looked the same and strange.

AmaiKinono commented 2 years ago

Yes it looks good.

In alacritty:

image

In konsole:

image

I'm not an expert of terminal display but these terminal emulators seem to be run in 256-color mode, at least that's how many colors I have when I run M-x list-colors-display.

This is in cool-retro-term (only 8 colors) and it still looks good:

image

Maybe (just maybe) it's a problem of macOS? I don't have access to macOS so I can't test myself.